Hi Martin, First of all thanks a lot for the hard work. Much appreciated. However there is other compilers like the Groovy Eclipse Compiler (https://github.com/groovy/groovy-eclipse/blob/d6ac73c6ba4adadbd67c60bf130ad68f2284890f/extras/groovy-eclipse-compiler/src/main/java/org/codehaus/groovy/eclipse/compiler/GroovyEclipseCompiler.java#L71C14-L71C35) which doesn’t implement javax.tools.JavaCompiler (yet). I opened https://github.com/groovy/groovy-eclipse/issues/1592 to raise an improvement request regarding this.
Konrad > On 23. Jul 2024, at 10:58, Martin Desruisseaux > <martin.desruisse...@geomatys.com> wrote: > > Le 2024-07-23 à 10 h 50, András Péteri a écrit : >> >> Class "org.eclipse.jdt.internal.compiler.tool.EclipseCompiler" does >> implement this interface (…snip…) name() is a default method on >> javax.tools.Tool and this implementation leaves it as-is, so it will return >> an empty String. >> > Looks good. I also see that this compiler is declared in META-INF: > > https://github.com/eclipse-jdt/eclipse.jdt.core/blob/8e630b6c235edaf7d6e757442b1ee2c5761b6021/org.eclipse.jdt.core.compiler.batch/META-INF/services/javax.tools.JavaCompiler > > Then a pull request for adding a name() method returning (I guess) "ecj" > should be everything needed. Putting the Eclipse JAR file on the class-path > at maven-compiler-plugin execution time would be sufficient for making this > compiler available. > > Martin > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org >
