PR seems ok https://github.com/apache/maven/pull/1735
@Martin Desruisseaux pls confirm is this what you had in mind? @Guillaume Nodet pls confirm the intent (and the assumption was it a bug, or we overlooked something?) T On Sat, Sep 21, 2024 at 4:57 PM Tamás Cservenák <ta...@cservenak.net> wrote: > > Lets see what this PR does > https://github.com/apache/maven/pull/1735 > > I agree with Martin, it really looks "sus"... > T > > On Sat, Sep 21, 2024 at 4:49 PM Guillaume Nodet <gno...@gmail.com> wrote: > > > > AFAIK, the Model.pomFile is null when the model is not a « build” Pom, I.e. > > is loaded from the local repository rather than a project being built. > > Not sure if that applies here, I’m on phone… > > > > Le sam. 21 sept. 2024 à 16:43, Tamás Cservenák <ta...@cservenak.net> a > > écrit : > >> > >> Howdy, > >> > >> AFAIK, as I see, the point is that it nullifies if "default" value is > >> present, and those come from corresponding super POM? > >> https://github.com/apache/maven/tree/45f9b81b4a8451a75864ef1c861c5bb201a54790/maven-api-impl/src/main/resources/org/apache/maven/model > >> > >> Basically, keep only the non-default values? > >> > >> @Guillaume Nodet > >> > >> T > >> > >> On Sat, Sep 21, 2024 at 4:19 PM Martin Desruisseaux > >> <martin.desruisse...@geomatys.com> wrote: > >> > > >> > Hello all > >> > > >> > I'm starting to work on a prototype using the new build <Source> element > >> > (a proposal for a unified replacement for <sourceDirectory>, > >> > <testDirectory>, <resources>, etc.) proposed in a previous discussion on > >> > this mailing list. For starting, I'm searching for usages of > >> > <sourceDirectory> in Maven source code and I try to add codes doing > >> > something equivalent for <Source>. > >> > > >> > However, a difficulty I'm facing is the quasi-absence of documentation > >> > in Maven source code. The vast majority of code has no comment at all. I > >> > miss in particular comments that would explain *why* a code is designed > >> > the way it is. One example I have met just now > >> > (DefaultModelPathTranslator at line 118): > >> > > >> > private String alignToBaseDirectory(String path, Path basedir) { > >> > String newPath = pathTranslator.alignToBaseDirectory(path, > >> > basedir); > >> > return Objects.equals(path, newPath) ? null : newPath; > >> > } > >> > > >> > This method is invoked for all well-known paths of the <build> element: > >> > <sourceDirectory>, <testDirectory>, <outputDirectory>, etc. But why this > >> > method sets the directory to null when there is no change? Is it a bug? > >> > Is it intended? Without comment explaining the intend, it is hard to > >> > guess. It is especially puzzling because just above that method, there > >> > is another method doing the exact opposite (returning the existing > >> > object when there is no change). > >> > > >> > For now, I will design the <Source> handling with the assumption that > >> > above null return value is a bug. But without documentation explaining > >> > method contract, there is a risk that I make wrong choices (the above > >> > case is just one example among many). > >> > > >> > Martin > >> > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
