Hi Eliotte, Not sure it is good for tests but for pom and main it shouldn't run apply (at least on the CI, can be locally) otherwise you would just hide the fact the style is not respected by formatting it locally on the CI in a PR for example and therefore merge the broken formatting (and defeating spotless setup).
Romain Manni-Bucau @rmannibucau <https://x.com/rmannibucau> | Blog <https://rmannibucau.metawerx.net/> | Old Blog <http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> | LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book <https://www.packtpub.com/en-us/product/java-ee-8-high-performance-9781788473064> Le ven. 29 nov. 2024 à 18:21, Elliotte Rusty Harold <elh...@ibiblio.org> a écrit : > While working on a third party plugin I noticed it was configured to > autorun spotless as part of "mvn test" (and probably other goals): > > [INFO] --- spotless:2.43.0:apply (default) @ spotbugs-maven-plugin --- > [INFO] Spotless.Format is keeping 10 files clean - 0 were changed to > be clean, 0 were already clean, 10 were skipped because caching > determined they were already clean > [INFO] Spotless.Format is keeping 182 files clean - 0 were changed to > be clean, 1 were already clean, 181 were skipped because caching > determined they were already clean > [INFO] > > We should do that too in our poms to avoid the recurring and annoying > problems of forgetting to run spotless manually and consequently > having a meaningless break in the CI that needs to be investigated. > Integrated over all of us this should save a few days of developer > time per year. > > I'd file a bug, but the way we've set up issue tracking this would be > one per repo, and I'm disinclined to file the same bug 40 times. Let's > just do it. > > -- > Elliotte Rusty Harold > elh...@ibiblio.org > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org > For additional commands, e-mail: dev-h...@maven.apache.org > >
