Folks, If anyone has a spare minute, I have a few dozen PRs that need code review or rereview:
https://github.com/pulls?page=1&q=is%3Aopen+is%3Apr+author%3Aelharo+archived%3Afalse+org%3Aapache+repo%3Aapache%2Fmaven Most of these focus on code modernization: 1. Using Guice constructor injection and javax.inject instead of Plexus field injection as recommended in the developer wiki. 2. Using try with resources instead of explicit close 3. Fully declaring and enforcing the dependencies of each plugin 4. Assorted code cleanups and doc edits that became apparent while working on the first three. One in the maven-pmd-plugin has an actual bug on Windows I haven't resolved yet, and a couple are in projects like maven-resources-plugin where the CI is broken at head. Otherwise tests are passing. If anyone has the time to look at any of these, it would be appreciated. YOu can ignore any that aren't in apache/maven*. I think those are all on the second page toward the end of the list. Thanks. -- Elliotte Rusty Harold elh...@ibiblio.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org
