Are all those bits of “compatibility code” annotated as @Deprecated? Later,
Andy From: Guillaume Nodet <gno...@apache.org> Date: Tuesday, 3 June 2025 at 09:20 To: Maven Developers List <dev@maven.apache.org> Subject: Re: current setup is leaking quality: [S1161] "@override" should be used on overriding members FWIW, most if not all of these changes are in compatibility (I.e. deprecated) code, so while it can be worth fixing things, we should focus on current / used code instead, so those changes are low priority imho. ------------------------ Guillaume Nodet Le mar. 3 juin 2025 à 09:47, Vincent Potucek <vpotu...@me.com.invalid> a écrit : Hello devs, Given the current state of the Maven codebase—where even basic conventions like proper @Override annotations are not consistently followed, and there's misalignment with JCC—it’s clear that things are out of control. There is a vacuum in chaos waiting to be filled with natural order and structure. Bringing in discipline through static code analysis tools is a straightforward and necessary step. At scale, humans inevitably introduce errors—it’s in our nature. We’re not always great at spotting or fixing them without help. That’s why automated tools are essential. This isn’t about opinion or individuals. It’s about acknowledging the system and its flaws—and improving it. The current setup is leaking quality, and it's risky to ignore that. Introducing tools like PMD and aligning with Sonar rules can help us catch and prevent issues early. Here are some relevant references: · RSPEC<https://sonarsource.github.io/rspec/#/rspec/S1161> sonarsource.github.io<https://sonarsource.github.io/rspec/#/rspec/S1161> [cid:ii_19734de7abaff2e9e641]<https://sonarsource.github.io/rspec/#/rspec/S1161> · · [cid:ii_19734de7aba9a7aab432] Add missing @Override to overriding and implementing methods by Pankraz76 · Pull Request #2402 · apache/maven<https://github.com/apache/maven/pull/2402> github.com<https://github.com/apache/maven/pull/2402> · · [PoC] rule: category/java/bestpractices.xml/MissingOverride by Pankraz76 · Pull Request #2403 · apache/maven<https://github.com/apache/maven/pull/2403> github.com<https://github.com/apache/maven/pull/2403> [cid:ii_19734de7abadc3f35c3]<https://github.com/apache/maven/pull/2403> · Let’s take this opportunity to level up our standards and tooling. My suggestion would be to align on some basic standards and start simple with a PoC for S1161, as this should be a common norm to align everybody—even those who have trouble letting things go. Best regards, Vinc The University of Edinburgh is a charitable body, registered in Scotland, with registration number SC005336. Is e buidheann carthannais a th’ ann an Oilthigh Dhùn Èideann, clàraichte an Alba, àireamh clàraidh SC005336.
