On Fri, 28 Nov 2025 at 14:08, Konrad Windszus <[email protected]> wrote:
> Hi, > What about https://github.com/apache/maven-release/pull/1431? > For me this would be a backwards incompatible change in 3.3.1 if we > release 3.3.0 as is. > change is in internal class Also https://github.com/apache/maven-release/pull/1431 seems relevant as > having a reference to org.semver.Version in our API ( > https://github.com/apache/maven-release/blob/cbdc4a7c483bbadff6e28ca48d2be80237780f05/maven-release-policies/maven-release-semver-policy/src/main/java/org/apache/maven/shared/release/policy/semver/AbstractSemVerVersionPolicy.java#L34C15-L34C22) > seems brittle (as this API seems to be no longer maintained, > https://mvnrepository.com/artifact/org.semver/api). > semver was used - it is not new added. We are working on removing semver, but is is not a blocker for next release for me https://github.com/apache/maven-release/pull/1430 > > So I would rather like to skip this and go ahead with 3.3.1 or respin > 3.3.0. > Ok, I will cancel it and respin, with mentioned fixes > > Although I do acknowledge that considering the classes in > https://github.com/apache/maven-release/tree/master/maven-release-policies/maven-release-semver-policy/src/main/java/org/apache/maven/shared/release/policy/semver > public API is probably a stretch I have seen things like this too often. > Better not risk breaking consumers and cancel 3.3.0 and streamline the API > first or at least add a javadoc stating that this is internal classes only > not supposed to be reused anywhere else. > To be clear, we can change the visibility of new classes. > > All that leads to me rather voting -1 in this case. > > Sorry for noticing late, as I know I have been reviewer for > https://github.com/apache/maven-release/pull/1424 but didn’t thoroughly > go through the changes earlier…. > No problem > > Konrad > > > On 26. Nov 2025, at 23:58, Slawomir Jaranowski <[email protected]> > wrote: > > > > Hi, > > > > We solved 20 issues: > > > https://github.com/apache/maven-release/issues?q=is%3Aclosed%20milestone%3A3.3.0 > > > > Changes since the last release: > > > https://github.com/apache/maven-release/compare/maven-release-3.2.0...maven-release-3.3.0 > > > > Staging repo: > > https://repository.apache.org/content/repositories/maven-2349/ > > > https://repository.apache.org/content/repositories/maven-2349/org/apache/maven/release/maven-release/3.3.0/maven-release-3.3.0-source-release.zip > > > > Source release checksum(s): > > maven-release-3.3.0-source-release.zip - SHA-512 : > > > 248aecd92b76d26ba83111ea9edf33515d1d56a42618d9fcb1ee5ff45fca6827080aa00ec014a006e3601b979234a630b292c88c760197c32a186bcc4f57e735 > > > > Staging site: > > https://maven.apache.org/maven-release-archives/maven-release-LATEST/ > > > > Guide to testing staged releases: > > https://maven.apache.org/guides/development/guide-testing-releases.html > > > > Vote open for at least 72 hours. > > > > [ ] +1 > > [ ] +0 > > [ ] -1 > > > > -- > > Sławomir Jaranowski > > -- Sławomir Jaranowski
