The following comment has been added to this issue:
Author: Tim Shadel
Created: Wed, 26 May 2004 7:07 PM
Body:
It's calling getCvsRoot() and others because Maven calls them. When I typed 'maven
clean', getScmType() threw an IllegalArgumentException. The function was changed to
call splitSCMConnection(), which requires 6 tokens (CVS specific). My first attempt
to fix this was to only require 6 tokens if the SCM was actually "cvs", but 'maven
clean' still didn't work. Somewhere in Maven there was a call to getCvsRoot(), the
problem was that the new implementation of that code required 4 tokens.
I'm not sure about the assumptions made throughout the Maven code, so instead of
trying to figure out why Maven was calling CVS specific functions when I've listed an
scm of type "svn", I decided it was easiest to go back to the old implementaions of
those functions and provide an alternate solution to removing the ":" delimiter.
The test calls those functions to ensure any future changes to their implementations
won't break with Subversion URLs. If you keep them there for now, they should be
removed once the pieces of Maven that use the Repository class only call such
functions when the SCM type is "cvs". It seemed the simplest way to write a test for
all the errors I encountered while trying to fix the problem.
---------------------------------------------------------------------
View this comment:
http://jira.codehaus.org/browse/MAVEN-1295?page=comments#action_20124
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/browse/MAVEN-1295
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MAVEN-1295
Summary: Subversion repository connection broken
Type: Bug
Status: Unassigned
Priority: Critical
Original Estimate: Unknown
Time Spent: Unknown
Remaining: Unknown
Project: maven
Versions:
1.0-rc3
Assignee:
Reporter: Tim Shadel
Created: Wed, 26 May 2004 5:46 PM
Updated: Wed, 26 May 2004 7:07 PM
Description:
RC3's change to the Repository class broke Subversion connections in a big way. I've
provided a patch that I think stays close to the intent of the change (remove the
hard-coded ":" delimiters), while staying close to the original code that allowed
Subversion URLs to work within the CVS-specific setup of the Repository class.
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
