Do we really care about sourceModifications? Should we generate it for everything, or will this double up?
That check can also check for the existence of JDK 1.4+ where the bugs in javadoc are fixed IIRC. - Brett Quoting Heritier Arnaud <[EMAIL PROTECTED]>: > Hello guys, > > Several weeks ago, I added the functionnality to use the > "maven.compile.src.set" in the javadoc plugin. > I also added like in others plugins, a patternset to exclude or > include files depending on the pom.build.sourceModifications.... > > To use the patternset I needed to give in entry to the javadoc task > a fileset and not a sourcepath. > > The use of a fileset create some problems : > - MPJAVADOC 28 : You can't use a link to a package name > - MPJAVADOC 29 : The jdk 1.3 doesn't generate the package list > > Yesterday, I committed some changes to the javadoc plugin. > From now the fileset is only used if a sourceModifications is > defined. Otherwise the plugin use a sourcepath. > > The problem is that the behaviour of the javadoc plugin is different > if the user define sourceModifications or not. > If the user define in its project some sourceModifications, he can > encounter the bugs MPJAVADOC 28 and/or 29. > > I think we can have 2 solutions. > Either we simplify the plugin and we remove the use of the > patternset or we allow the user decide with a property if he want to use > it ? > > What do you think about this ? Is there a better solution ? > > > Arnaud > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]