Mmm, yesterday I've run the tests and succeeded. I'm gonna check if I missed something.
Don't worry I'll take a look now. > -----Original Message----- > From: Dion Gillard [mailto:[EMAIL PROTECTED] > Sent: Monday, July 05, 2004 3:32 PM > To: Maven Developers List > Subject: Re: RE : cvs commit: > maven-plugins/ant/src/plugin-test maven.xml > > Those files are already there. They're in the > src/plugin-test/src directory. > > I think the changes to maven.xml were wrong. > > The lines: > <!-- use relative paths --> > <j:set var="baseDirFile" > value="${pom.file.canonicalFile.parentFile}"/> > <maven:makeRelativePath basedir="${baseDirFile}" > path="${maven.build.dest}" separator="/" var="classesdir"/> > <maven:makeRelativePath basedir="${baseDirFile}" > path="${maven.test.dest}" separator="/" var="testclassesdir"/> > > were added by carlos, and I think they're not valid. > > Instead of checking the build.xml contains relative files, he > added some relative paths to the existing checks - not quite > right as far as I can tell. > > On Mon, 5 Jul 2004 15:14:17 +0200, Heritier Arnaud > <[EMAIL PROTECTED]> wrote: > > Hello Carlos ! > > > > Can you add these files on CVS : > > ${maven.build.dest}/directory-1/file1.properties > > ${maven.build.dest}/file2.properties > > ${maven.test.dest}/directory-1/file1.properties > > ${maven.test.dest}/file2.properties > > > > An issue was opened by Dion (MPANT-17) > > > > Thanks. > > > > > -----Message d'origine----- > > > De : [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] Envoyé > : dimanche > > > 4 juillet 2004 17:31 À : [EMAIL PROTECTED] Objet : cvs > > > commit: maven-plugins/ant/src/plugin-test maven.xml > > > > > > > > > > > > > carlos 2004/07/04 08:31:22 > > > > > > Modified: ant/src/plugin-test maven.xml > > > Log: > > > Use relative paths in directory properties. Issue MPANT-16 > > > > > > Revision Changes Path > > > 1.6 +12 -5 maven-plugins/ant/src/plugin-test/maven.xml > > > > > > Index: maven.xml > > > > =================================================================== > > > RCS file: > /home/cvs/maven-plugins/ant/src/plugin-test/maven.xml,v > > > retrieving revision 1.5 > > > retrieving revision 1.6 > > > diff -u -r1.5 -r1.6 > > > --- maven.xml 22 May 2004 03:00:20 -0000 1.5 > > > +++ maven.xml 4 Jul 2004 15:31:22 -0000 1.6 > > > @@ -18,6 +18,7 @@ > > > <project xmlns:util="jelly:util" > > > xmlns:j="jelly:core" > > > xmlns:ant="jelly:ant" > > > + xmlns:maven="jelly:maven" > > > xmlns:assert="assert"> > > > > > > <goal name="testPlugin" prereqs="test-ant"> > > > @@ -31,12 +32,18 @@ > > > > > > <ant:property name="noget" value="noget" /> > > > <ant:ant/> > > > - > > > - <assert:assertFileExists > > > file="${maven.build.dest}/directory-1/file1.properties"/> > > > - <assert:assertFileExists > > > file="${maven.build.dest}/file2.properties"/> > > > - <assert:assertFileExists > > > file="${maven.test.dest}/directory-1/file1.properties"/> > > > - <assert:assertFileExists > > > file="${maven.test.dest}/file2.properties"/> > > > + > > > + <!-- use relative paths --> > > > + <j:set var="baseDirFile" > > > value="${pom.file.canonicalFile.parentFile}"/> > > > + <maven:makeRelativePath basedir="${baseDirFile}" > > > path="${maven.build.dest}" separator="/" var="classesdir"/> > > > + <maven:makeRelativePath basedir="${baseDirFile}" > > > path="${maven.test.dest}" separator="/" var="testclassesdir"/> > > > + > > > + <assert:assertFileExists > > > file="${classesdir}/directory-1/file1.properties"/> > > > + <assert:assertFileExists > > > file="${classesdir}/file2.properties"/> > > > + <assert:assertFileExists > > > file="${testclassesdir}/directory-1/file1.properties"/> > > > + <assert:assertFileExists > > > file="${testclassesdir}/file2.properties"/> > > > > > > <delete file="${basedir}/build.xml"/> > > > </goal> > > > + > > > </project> > > > > > > > > > > > > > > > > -------------------------------------------------------------------- > > > - To unsubscribe, e-mail: [EMAIL PROTECTED] For > > > additional commands, e-mail: [EMAIL PROTECTED] > > > > > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [EMAIL PROTECTED] For > > additional commands, e-mail: [EMAIL PROTECTED] > > > > > > > -- > http://www.multitask.com.au/people/dion/ > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] For > additional commands, e-mail: [EMAIL PROTECTED] > > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
