The following comment has been added to this issue:
Author: Vincent Massol
Created: Wed, 14 Jul 2004 5:14 PM
Body:
Hi Felipe,
Thanks for the patch. Here are some comments/questions:
1/ I'm interested to know why you need to provide your own stylesheet. Is there
anything missing in the existing that we could add? How are you using the new
properties you've set?
2/ I don't think there's a need for the stylesheet "Type". Simply define the location
and you're done.
3/ Yes, there should be unit tests. We need to add tests. Have a look at some other
plugins like checkstyle, changes, etc. Check in src/plugin-test. Tests are run by
calling "maven plugin:test".
Thanks!
-Vincent
---------------------------------------------------------------------
View this comment:
http://jira.codehaus.org/browse/MPANNOUNCEMENT-11?page=comments#action_21781
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/browse/MPANNOUNCEMENT-11
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MPANNOUNCEMENT-11
Summary: [PATCH] Option to set different templates to be used as announcement
Type: Improvement
Status: Unassigned
Priority: Major
Original Estimate: 15 minutes
Time Spent: Unknown
Remaining: 15 minutes
Project: maven-announcement-plugin
Assignee:
Reporter: Felipe Leme
Created: Tue, 13 Jul 2004 1:54 PM
Updated: Wed, 14 Jul 2004 5:14 PM
Environment: maven-plugins from CVS main branch
Description:
Hi Vince,
It would be nice to allow using different templates (i.e., stylesheet) for the
announcement file.
I did some changes (not sure if they're the best, as Jelly is very tricky :-) at
plugin.jelly, so now it looks for the following properties in order to define the
stylesheet:
maven.announcement.stylesheet.locationType
maven.announcement.stylesheet.locationValue
locationType determines the context where the stylesheet is located (right now:
resource, uri or project) and locationValue is the path per see - I'm describing the
process in more details on xdocs/properties.xml.
So, I'm sending a patch created from the CVS branch (I've set the currentVersion as
1.3-SNAPSHOT in the project.xml and xdocs/changes.xml included in the patch)
Regards,
Felipe (felipeal at ASF)
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
