I prefer <j:set var="maven.build.dest" value="${tmp}" scope="parent" /> for the
below.I think we can reasonably update with <maven:get/> as well as we go past these things, so that the other stuff fades out faster :) Getting back to the real work, is this to facilitate "clover:on cactus" working? Will it be workable in the reports somehow? I'm particularly interested in getting jcoverage over cactus tests. Cheers, Brett Quoting Vincent Massol <[EMAIL PROTECTED]>: > > > -----Original Message----- > > From: Emmanuel Venisse [mailto:[EMAIL PROTECTED] > > Sent: vendredi 16 juillet 2004 14:01 > > To: Maven Developers List > > Subject: Re: cvs commit: maven-plugins/clover/xdocs changes.xml > > > > Vincent, > > > > Can you use maven set tag instead og deprecated api. > > I wasn't making this change here, I was working on a totally different topic > and I don't like mixing different tasks in the same commit... > > That said, the maven:set tag is there to set a property in a given plugin. > This is *NOT* what I'm doing here: > > ${context.getParent().setVariable('maven.build.dest',tmp)} > > Thanks > -Vincent > > > > > Emmanuel > > > > ----- Original Message ----- > > From: <[EMAIL PROTECTED]> > > To: <[EMAIL PROTECTED]> > > Sent: Friday, July 16, 2004 12:59 PM > > Subject: cvs commit: maven-plugins/clover/xdocs changes.xml > > > > > > > vmassol 2004/07/16 03:59:37 > > > > > > Modified: clover plugin.jelly > > > clover/xdocs changes.xml > > > Log: > > > When executing <code>clover:on</code> and <code>clover:off</code>, > > modify the <code>maven.build.dest</code> property value in the Root > > context > > of all plugins so that the value change is available in all Maven plugins. > > > > > > Revision Changes Path > > > 1.28 +4 -10 maven-plugins/clover/plugin.jelly > > > > > > Index: plugin.jelly > > > =================================================================== > > > RCS file: /home/cvs/maven-plugins/clover/plugin.jelly,v > > > retrieving revision 1.27 > > > retrieving revision 1.28 > > > diff -u -r1.27 -r1.28 > > > --- plugin.jelly 16 Jul 2004 09:47:39 -0000 1.27 > > > +++ plugin.jelly 16 Jul 2004 10:59:37 -0000 1.28 > > > @@ -158,12 +158,8 @@ > > > <echo>Now using primary build.compiler : ${build.compiler}</echo> > > > > > > <j:set var="tmp" value="${maven.clover.build.classes}"/> > > > - <j:set var="mavenBuildDestJavaOld" > > > - > > value="${pom.getPluginContext('maven-java- > > plugin').getVariable('maven.build. > > dest')}"/> > > > - > > ${pom.getPluginContext('maven-java- > > plugin').setVariable('maven.build.dest',t > > mp)} > > > - <j:set var="mavenBuildDestTestOld" > > > - > > value="${pom.getPluginContext('maven-test- > > plugin').getVariable('maven.build. > > dest')}"/> > > > - > > ${pom.getPluginContext('maven-test- > > plugin').setVariable('maven.build.dest',t > > mp)} > > > + <j:set var="mavenBuildDestOld" > > value="${context.parent.getVariable('maven.build.dest')}"/> > > > + ${context.getParent().setVariable('maven.build.dest',tmp)} > > > > > > </goal> > > > > > > @@ -175,10 +171,8 @@ > > > --> > > > <goal name="clover:off"> > > > > > > - > > ${pom.getPluginContext('maven-test- > > plugin').setVariable('maven.build.dest',m > > avenBuildDestTestOld)} > > > - > > ${pom.getPluginContext('maven-java- > > plugin').setVariable('maven.build.dest',m > > avenBuildDestJavaOld)} > > > - > > > - ${pom.getContext().removeVariable('build.compiler')} > > > + > > ${context.getParent().setVariable('maven.build.dest',mavenBuildDestTestOld > > )} > > > + ${context.removeVariable('build.compiler')} > > > > > > <j:set var="maven.test.failure.ignore" scope="parent" > > value="${ignoreTestFailureOld}"/> > > > <j:set var="maven.junit.fork" scope="parent" > > value="${junitForkOld}"/> > > > > > > > > > > > > 1.33 +5 -0 maven-plugins/clover/xdocs/changes.xml > > > > > > Index: changes.xml > > > =================================================================== > > > RCS file: /home/cvs/maven-plugins/clover/xdocs/changes.xml,v > > > retrieving revision 1.32 > > > retrieving revision 1.33 > > > diff -u -r1.32 -r1.33 > > > --- changes.xml 16 Jul 2004 09:47:39 -0000 1.32 > > > +++ changes.xml 16 Jul 2004 10:59:37 -0000 1.33 > > > @@ -27,6 +27,11 @@ > > > <body> > > > <release version="1.6-SNAPSHOT" date="in CVS"> > > > <action dev="vmassol" type="fix"> > > > + When executing <code>clover:on</code> and > > <code>clover:off</code>, modify > > > + the <code>maven.build.dest</code> property value in the Root > > context of > > > + all plugins so that the value change is available in all > > Maven > > plugins. > > > + </action> > > > + <action dev="vmassol" type="fix"> > > > Prevented the <code>clover:on</code> goal from failing when > > there are > > > no unit tests sources available. > > > </action> > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > > > > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [EMAIL PROTECTED] > > For additional commands, e-mail: [EMAIL PROTECTED] > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
