The following comment has been added to this issue:

     Author: Felipe Leme
    Created: Wed, 28 Jul 2004 7:01 AM
       Body:
Hi Vincent,

Some COC (comments on comments :-) inline:

> What is the use case for the mail-all goal?

Consistency. If there is a generate-all, why not a mail-all? I created just the mail 
originally, but then when I wrote the full patch (i.e., goals.xml, properties.xml, 
etc..) I realized there was a generate-all, so it might make sense to have a mail-all 
too.

> - I have put the public properties in plugin.properties

Sorry, I forgot that one :-(

>- I have have introduced %VERSION% template in subject property
Cool. That would solve the problem of resolving the ${versionVariable} on mail-all at 
'runtime' . In fact, my first idea to the problem was using such a variable 
replacement schema, but I didn't know it was a common practice (on Maven plugins) and 
was afraid the final result would be too complex (guess next time I should be asking 
these questions in the dev list first :-)

> - javamail jar not on ibiblio... We cannot release the plugin. We need to find an 
> alternative jar
Initially, I thought that could be an issue too, so I checked what the jelly-tag-email 
does, and they use javamail. But looks like they have the same issue, as there is no 
official release yet. Do you know any replacement? After a quick look on ibiblio, the 
closest I found was james, which is ASF's Java-bases email server (as they use ASL, 
they might use an alternative for JavaMail)

> - Used maven:param-check instead of manual checks
Cool, I didn't know that trick.



---------------------------------------------------------------------
View this comment:
  http://jira.codehaus.org/browse/MPANNOUNCEMENT-9?page=comments#action_22443

---------------------------------------------------------------------
View the issue:
  http://jira.codehaus.org/browse/MPANNOUNCEMENT-9

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: MPANNOUNCEMENT-9
    Summary: Add a goal to send the announcement by mail to a list of email addresses
       Type: New Feature

     Status: Open
   Priority: Major

 Original Estimate: Unknown
 Time Spent: Unknown
  Remaining: Unknown

    Project: maven-announcement-plugin
   Versions:
             1.2

   Assignee: Vincent Massol
   Reporter: Vincent Massol

    Created: Thu, 8 Jul 2004 4:16 AM
    Updated: Wed, 28 Jul 2004 7:01 AM

Description:



---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to