> -----Original Message----- > From: Emmanuel Venisse [mailto:[EMAIL PROTECTED] > Sent: mardi 17 août 2004 17:30 > To: Maven Developers List > Subject: Re: cvs commit: maven-plugins/abbot/src/plugin-resources jnlp.jsl > > > > > > Hi Vincent, > > > > > > > > > > Why you don't use the jnlp plugin? Do you have some specific > > > requirement? > > > > > > > > I need to take an existing JNLP file and add some items to it. Is > that > > > > supported by the JNLP plugin? > > > > > > No, but we can add a merge goal (or tag) for merge two files. > > > I think it's a better idea. > > > > Even if you add this it won't help me, because I don't have 2 JNLP > files. > I > > have only one JNLP file and some plugin logic that needs to be inserted > in > > the JNLP. Making it generic would be too difficult (template) and I > really > > don't see what it would have to do with the JNLP plugin... > > It's not really 2 jnlp files but 1 jnlp file and a "patch" > For abbot you can create a patch like this : > <jnlp> > <resources> > <!-- your specific jar add --> > <!-- your specific properties add --> > </resources> > </jnlp> > Note that I only write the specific part. > > We merge original jar part with your part and original properties part > with > your part. > > So, for all jnlp tags, we write original part + patch part.
Sorry but I fail to understand how it would be better than what currently exists (I find it worse as it creates an unnecessary dependency with the JNLP plugin and it looks like it's the same amount of code). I don't have much time to work on this but feel free to create a JIRA patch for the Abbot plugin if you're interested and I'll have a look. Thanks -Vincent --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
