The following issue has been updated:

    Updater: Felipe Leme (mailto:[EMAIL PROTECTED])
       Date: Sun, 22 Aug 2004 10:28 PM
    Comment:
Brett,

Here is a new patch. I haven't tested it yet (I couldn't test 'maven site:generate' 
due to a missing cvs/netbeans lib, among othe problems), but it should be ok.

Anyway, it adds the following properties

jar plugin -> maven.jar.final.name
ejb plugin -> maven.ejb.client.final.name
rar plugin -> maven.rar.final.name

Note also that some of the proposed properties were already in the code:

ejb plugin -> maven.ejb.final.name
war plugin -> maven.war.final.name

I haven't changed the plugins changes.xml neither.

Felipe

PS: as the original reporter mentioned, this patch should not change any of the 
current functionality. On the other hand, even if the properties are changed by the 
user, the artifact tags will still install/deploy the artifacts using the old name. I 
have already opened an issue for that (MPARTIFACT-35), so I think this patch per se is 
fine.

 
    Changes:
             Attachment changed to MPJAVA-8-new1.patch
    ---------------------------------------------------------------------
For a full history of the issue, see:

  http://jira.codehaus.org/browse/MPJAVA-8?page=history

---------------------------------------------------------------------
View the issue:
  http://jira.codehaus.org/browse/MPJAVA-8

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: MPJAVA-8
    Summary: Consistent properties for jar, war, ejb and ear
       Type: Improvement

     Status: Unassigned
   Priority: Major

 Original Estimate: Unknown
 Time Spent: Unknown
  Remaining: Unknown

    Project: maven-java-plugin

   Assignee: 
   Reporter: Aslak Hellesoy

    Created: Tue, 25 Mar 2003 5:11 AM
    Updated: Sun, 22 Aug 2004 10:28 PM

Description:
The current naming conventions for properties defining the names of jar, ejb, war and 
ear are somewhat inconsistent.

This patch introduces 4 new properties:

# defined in the java plugin's plugin.properties
maven.jar.final.name = ${maven.final.name}.jar

# defined in the war plugin's plugin.properties
maven.war.final.name = ${maven.final.name}.war

# defined in the ejb plugin's plugin.properties
maven.ejb.final.name = ${maven.final.name}.jar

# defined in the ear plugin's plugin.properties
maven.ear.final.name = ${maven.final.name}.ear

This patch solves the following problems:

1) It removes the risk of name clashes for projects that produce both plain
jar files and ejb jar files, since the maven.ejb.final.name property can be overridden.

2) When packaging wars and ejbs inside ears, it is sometimes desirable to have 
different names for ejbs and wars, like foo-ejb-1.0.jar and foo-war-1.0.war. This is 
necessary when the contents of an ear file is to be deployed on different weblogic 
servers with weblogic.deploy. This can now be achieved by overriding 
maven.ejb.final.name and/or maven.war.final.name.

This patch should not change any of the current functionality, and the documentation 
has been updated too.



---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to