The following issue has been updated:

    Updater: Michael Gaffney (mailto:[EMAIL PROTECTED])
       Date: Tue, 5 Oct 2004 1:55 PM
    Comment:
I've attached a patch to fix this problem.  I moved version information about a 
package from the 'main' manifest section to a package section.  I looked at manifest 
files for other projects (like ant and xalan) and noticed they were also doing it this 
way.  An added benefit is that it would now be possible to correctly merge two jar 
files and their manifest files.

I deleted the setting of the 'Created-By' attribute because the ant manifest task 
correctly sets this with the java version used to generate the manifest file (which is 
what the Sun spec says it should be).  This info was previously captured in the 
non-standard 'Build-Jdk' attribute which I removed because it was redundant. 

    Changes:
             Attachment changed to patch.txt
    ---------------------------------------------------------------------
For a full history of the issue, see:

  http://jira.codehaus.org/browse/MPJAR-36?page=history

---------------------------------------------------------------------
View the issue:
  http://jira.codehaus.org/browse/MPJAR-36

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: MPJAR-36
    Summary: Jar plugin generate incorrect manifest file
       Type: Bug

     Status: Unassigned
   Priority: Critical

 Original Estimate: Unknown
 Time Spent: Unknown
  Remaining: Unknown

    Project: maven-jar-plugin
   Versions:
             1.5

   Assignee: 
   Reporter: Eugene Kuleshov

    Created: Thu, 5 Aug 2004 12:58 AM
    Updated: Tue, 5 Oct 2004 1:55 PM

Description:
Current jar plugin genrate an invalid manifest file. In particular it is impossible to 
retrieve package version information for jars created by this plugin. See more details 
at http://java.sun.com/j2se/1.4.2/docs/guide/jar/jar.html#JAR%20Manifest

Here is the example of current generated manifest file:

----------
Manifest-Version: 1.0
Ant-Version: Apache Ant 1.5.3 
Created-By: Apache Maven
Built-By: Administrator
Package: org.codehaus.activemq.jms.cci
Build-Jdk: 1.4.2_02
Class-Path:  commons-logging-1.0.3.jar log4j-1.2.8.jar
Extension-Name: ra-jms
Specification-Title: 
Specification-Vendor: 
Implementation-Title: org.codehaus.activemq.jms.cci
Implementation-Vendor: 
Implementation-Version: 0.0.2

----------

And this is about how it should look like instead:

------------
Manifest-Version: 1.0
Ant-Version: Apache Ant 1.5.3 
Created-By: 1.4.2_02-b03 (Sun Microsystems Inc.)
Class-path:  commons-logging-1.0.3.jar log4j-1.2.8.jar

Name: org/codehaus/some/component/
Specification-Title: something
Specification-Vendor: 
Specification-Version: 0.0.2
Implementation-Title: org.codehaus.activemq.jms.cci
Implementation-Vendor: 
Implementation-Version: 0.0.2

--------------------------


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to