Hi Brett,
> -----Original Message-----
> From: Brett Porter [mailto:[EMAIL PROTECTED]
> Sent: mardi 2 novembre 2004 12:44
> To: Maven Developers List
> Subject: Re: Some questions on dist plugin and proposal for improvement
>
> >Hi Mavens,
> >
> >I was browsing through the dist plugin source code and I have a few
> >questions/remarks/proposal:
> >
> >1/ Are the following properties used at all or can they be deleted:
> >maven.dist.tar.executable=tar
> >maven.dist.gunzip.executable=gunzip
> >
> >
> They can now be removed.
Done.
>
> >2/ Why is there a dependency to the jar:jar goal in the dist plugin? What
> if
> >I'm building a WAR? Wouldn't it be better if the dist does not call any
> >artifact building code at all (letting the user do it) or if the goal
> called
> >is pluggable?
> >
> >Note: This is also required if the artifact is built by a top level
> >multiproject goal (I have such a need in Cargo where I aggregate several
> >jars into a single big one).
> >
> >
> I don't think dist was ever built to consider wider use cases.
>
> >I think we would need 2 properties:
> >- one for specifying a goal to call (the goal that generates the
> artifacts
> >to include in the distrib)
> >
> >
> that's simple enough. Should be more than one goal though.
I was thinking that in case more goals are required, the user could create a
single custom dist goal in his maven.xml for this. But I'm also ok to
provide a list of goals in the property.
[snip]
> >3/ Same question for the site: what if I'm building a multiproject and
> the
> >site goal is multiproject:site or a custom goal?
> >
> >
> I think in both your question is "what if I'm bundling more than one
> project into a single distribution". I think it is more complicated than
> just adding in some more properties.
I'm thinking in term of the Maven projects I know of and so far with these
properties I think it fit the bill. Do you have any use case where this
would not be enough?
>
> >We would also need 2 properties:
> >- one for specifying the goal to call that generates the site
> >- one for specifying the generates doc directory (would default to
> >${maven.docs.dest})
> >
> >
> I'm not sure why these are needed.
That's the same as for the artifacts. The user must tell us how he generates
the documentation he wants to bundle in the distribution. First he tells
what artifacts he wants to bundle and then he tells us what docs he wants
in.
>
> >4/ Could we add 2 properties:
> >- maven.dist.type.zip = true|false
> >- maven.dist.type.targz = true|false
> >
> >They would both default to true.
> >
> >
> >
> .tarbz2, -src.targz, etc.
> and maybe
> .exe (we already have nsis using dist), .sh, .tar, .jar, .ace, .rar, ...
>
> How many properties can we add?
As many as there are "if" in the Handler... :-)
ATM, there are 2 supported distribution types: zip and tar.gz.
ATM, they are both mandatory. Do you think they should be kept mandatory?
>
> I don't think this is a problem solved by adding properties. We need a
> better way to map out distributions and handle project aggregation.
I'm not following you. If you're saying we need a "Solution" kind of feature
that explains what to do with the output of the different subprojects, I'm
all with you. However, the implementation of this feature will not be done
right now as it involves an architectural shift in Maven. In this thread I
was focusing on the existing m1 and how to simply make the "dist" plugin
usable for current m1 users.
Thanks
-Vincent
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
