I'm not sure exactly what the build dependencies are (I can't really read 
jelly/jsl code  that well) but I think some of the dependencies are handled 
before we get to this step, since it the performJSL tag is called for 
srcdir="${maven.gen.docs}" and srcdir="${maven.docs.src}" and the "uptodate" 
check is called inside a j:forEach loop.  So, I *think* some of the 
dependencies you mentioned may have already been handled.

I'm pretty sure that the site.jsl and navigation dependencies should be handled 
within this "uptodate" tag.  I'm just not comfortable enough with the jelly, 
jsl, etc. to be comfortable trying to handle all the dependencies.

The patch that I have does accelerate my build significantly when things 
haven't changed, but there  is a risk that someone could be burned by a 
dependency not being handled and a source change not being reflected in the 
generated site.

I went ahead and submitted a JIRA issue with a patch.
(http://jira.codehaus.org/browse/MPXDOC-141)
This is what I have so far, but hopefully someone who understands the XDOC 
plugin better than me will improve the patch and apply it.

-- Sean

>You might want to include some more source files for the uptodate check.  The 
>pom, the site.jsl or custom jsl, navigation.xml, properties files, and other 
>files all contribute to the site contents.
>
>Just a thought as your single file check is definately better than nothing.
>
>Brent
>
>----- Original Message -----
>From: "M. Sean Gilligan" <[EMAIL PROTECTED]>
>To: dev@maven.apache.org
>Subject: XDOC Plugin Optimization
>Date: Fri, 22 Apr 2005 07:08:21 -0700
>
>>
>> I've wanted to speed up the "maven site" command be eliminating tranforms of
>> unchanged documents for some time now.  I added some code to the XDOC plugin
>> that seems to work:
>>
>> <j:set var="varname" value="up${file.toString()}"/>
>> <uptodate
>>    property="${varname}"
>>    srcfile="${file.toString()}"
>>    targetfile="${outFile.toString()}" />
>>
>> <j:choose>
>>      <j:when test="${context.getVariable(varname)}">
>>          <echo>${outFile} is up to date.</echo>
>>      </j:when>
>>      <j:otherwise>
>>
>>       DO TRANSFORM AS BEFORE
>>
>>      </j:otherwise>
>> </j:choose>
>>
>> Is there anything wrong with this approach?  Should I submit a patch?
>> (I also made the same change to the html2xdoc plugin)
>>
>> There are also some ant image and stylesheet copies that seem to me should
>> have overwrite="false" to eliminate redundant copies.  Is there a reason for
>> overwrite="true"?
>>
>> Cheers,
>>
>> Sean
>> --
>> ---------------------------------------------------------------------------
>> M. Sean Gilligan                    : 831-466-9788 x11
>> vBlog Central                            : http://www.vblogcentral.com
>> ---------------------------------------------------------------------------
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [EMAIL PROTECTED]
>> For additional commands, e-mail: [EMAIL PROTECTED]
>
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: [EMAIL PROTECTED]
>For additional commands, e-mail: [EMAIL PROTECTED]


-- 
---------------------------------------------------------------------------
M. Sean Gilligan                    : 831-466-9788 x11
vBlog Central                       : http://www.vblogcentral.com
---------------------------------------------------------------------------

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to