[ http://jira.codehaus.org/browse/MNG-148?page=comments#action_39053 ]
     
Brett Porter commented on MNG-148:
----------------------------------

> Use the dependencies/dependency tags to identify the artifact to put in the 
> EAR. Problem: apparently the properties element is not supported in M2

correct. Include all runtime dependencies, and use exclusion patterns. 
(inclusion patterns have a problem in having to know the transitive deps).

> The excludeDependency Pattern can be groupId:artifactId:type for some case 
> where users have two deps with the same groupId/artifactId. 

This makes sense - you probably want to include an EJB in an EAR and not it's 
client, for example.

>  For this plugin, I'd want to have only one mojo.
> The ear builder and the application.xml generator must be in the same mojo. 
> Application.xml will be generated if user configure it. 

I don't agree, I think mojos should have discreet tasks to make them more 
reusable (although I guess that the EAR mojo could always do this and just 
share the code with a generate descriptor mojo?)

> I prefer to use the plugin configuration for include/exclude dependencies, 
> but you can support some replacement character like '*' for limit the 
> configuration.

I agree with this.




> Write an ear mojo
> -----------------
>
>          Key: MNG-148
>          URL: http://jira.codehaus.org/browse/MNG-148
>      Project: m2
>         Type: Task
>   Components: maven-plugins
>     Reporter: Emmanuel Venisse
>     Assignee: Emmanuel Venisse
>      Fix For: 2.0-alpha-3

>
>
> - Use Plexus Archiver
> - Add all features present in m1 plugin (ear:ear, ear:generate-ear-descriptor)

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to