Author: brett
Date: Tue Jun 21 05:16:26 2005
New Revision: 191653

URL: http://svn.apache.org/viewcvs?rev=191653&view=rev
Log:
comment and clean up

Modified:
    
maven/components/trunk/maven-core/src/main/java/org/apache/maven/plugin/DefaultPluginManager.java

Modified: 
maven/components/trunk/maven-core/src/main/java/org/apache/maven/plugin/DefaultPluginManager.java
URL: 
http://svn.apache.org/viewcvs/maven/components/trunk/maven-core/src/main/java/org/apache/maven/plugin/DefaultPluginManager.java?rev=191653&r1=191652&r2=191653&view=diff
==============================================================================
--- 
maven/components/trunk/maven-core/src/main/java/org/apache/maven/plugin/DefaultPluginManager.java
 (original)
+++ 
maven/components/trunk/maven-core/src/main/java/org/apache/maven/plugin/DefaultPluginManager.java
 Tue Jun 21 05:16:26 2005
@@ -558,8 +558,6 @@
 
                 Map resolved = result.getArtifacts();
 
-                List files = new ArrayList();
-
                 for ( Iterator it = resolved.values().iterator(); 
it.hasNext(); )
                 {
                     Artifact artifact = (Artifact) it.next();
@@ -572,6 +570,10 @@
 
                 pluginDescriptor.setClassRealm( 
pluginContainer.getContainerRealm() );
 
+                // TODO: this is probably overkill as it is rarely used - can 
we use a mojo tag to signal this will be
+                // used or check its configuration? Also, when it is used, 
perhaps it is more effecient to resolve
+                // everything at once and apply the exclusion filter when 
constructing the plugin container above.
+                // Check this out with yourkit
                 ArtifactFilter distroProvidedFilter = new 
InversionArtifactFilter( artifactFilter );
 
                 ArtifactResolutionResult distroProvidedResult = 
artifactResolver



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to