Emmanuel Venisse wrote:


Phil Steitz wrote:

Brett Porter wrote:

Looks ok to me, though I don't know why we shouldn't just drop the
ant:cvs part altogether and use scm:checkout as you have in the
otherwise blocks. What do you think?



I tried that but could not get cvs to work in a way that would preserve backward compatibility. I will play with this some more.


backward compatibility will be preserve with scm:checkout. In the 2 cases we use the scm connection string, so it will be transparent for users. What is your problem?

Two problems - first, I can't seem to get the ant properties maven.jdiff.old.src and maven.jdiff.new.src to work correctly for both cvs and svn - I will play with this some more and introduce a switch if necessary. Second, I was worried about users who may have set the old cvsModule and cvsRoot properties explicitly. Playing with this some more, it now looks to me as though these are imputed from the repository connection string. Is that correct?

Phil

Emmanuel


Phil


Emmanuel, do you have any thoughts? I'm not overly familiar with the plugin.

- Brett

Phil Steitz wrote:


Last week I added a patch to MPJDIFF-6 here:
http://jira.codehaus.org/browse/MPJDIFF-6?page=all
Comments?

Phil

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]





---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]





---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to