[ http://jira.codehaus.org/browse/MNG-645?page=comments#action_43445 ]
Vincent Massol commented on MNG-645: ------------------------------------ Yes, the other option is to have an abstract AbstractMavenReport.isExternalReport() method that report mojo must implement but I thought it would be better for the Mojo to choose the base class to extend instead. Sounds a bit cleaner to me but YMMV. BTW, it isn't just about generation of an empty file but also about site resources copying. > Allow for external reports > -------------------------- > > Key: MNG-645 > URL: http://jira.codehaus.org/browse/MNG-645 > Project: Maven 2 > Type: Task > Components: maven-reports > Versions: 2.0-alpha-3 > Reporter: Vincent Massol > Priority: Minor > Fix For: 2.0-beta-1 > > > Currently the AbstractMavenReport implementation has: > public void execute() > throws MojoExecutionException > { > try > { > String outputDirectory = getOutputDirectory(); > XhtmlSink sink = getSiteRenderer().createSink( new File( > outputDirectory ), getOutputName() + ".html", > outputDirectory, > getSiteDescriptor(), "maven" ); > [...] > This means that an HTML file with the report name will always be created. > However, for the Clover plugin the HTML files are generated by the Clover API > itself and we don't control them. Thus we don't need this clover.html file. > I believe the AbstractMavenReport class should support report mojos that have > externally generated HTML files too. > For now, I've implemented MavenReport instead of extending > AbstractMavenReport. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
