[ http://jira.codehaus.org/browse/MPDIST-25?page=comments#action_43662 ]
Trygve Laugstol commented on MPDIST-25: --------------------------------------- build.properties should not be included in the source distribution. For example it's normal to have passwords there, user specific paths etc which are more likely than not to break the build for other users on other machines. If your build requires special settings from a user I suggest that you include that in a file called BUILDING in the root of your project and/or have checks for that the values are set and correct in a preGoal in your maven.xml > Goal dist:prepare-src-filesystem should also include build.properties in > source distribution. > --------------------------------------------------------------------------------------------- > > Key: MPDIST-25 > URL: http://jira.codehaus.org/browse/MPDIST-25 > Project: maven-dist-plugin > Type: Improvement > Environment: Not of importance. > Reporter: Davy Toch > > Original Estimate: 2 hours > Remaining: 2 hours > > The following target call > <ant:copy todir="${maven.dist.src.assembly.dir}"> > <ant:fileset dir="."> > <ant:include name="README.txt"/> > <ant:include name="LICENSE*"/> > <ant:include name="project.properties"/> > <ant:include name="maven.xml"/> > <ant:include name="project.xml"/> > </ant:fileset> > </ant:copy> > in the goal dist:prepare-src-filesystem should also include the file > build.properties. Normally this file only includes user-specific settings. > When this file is not included in the source distribution, the developer > receiving the source distribution doesn't know which user-specific properties > to set. > On the other hand it would be useful to add a section at > http://maven.apache.org/reference/plugins/dist/ that indicates that if more > files from the project root need to be added in the source distribution, then > a postGoal for the above goal needs to be created in a custom maven.xml, for > example something like: > <!-- > Maven dist plugin doesn't copy build.properties (contains user-specific > settings) to source distribution. Additionally, it is sometimes > interesting > to also have the POM xsd in the project root and have it included as well > in the source distribution. > --> > <postGoal name="dist:prepare-src-filesystem"> > <copy todir="${maven.dist.src.assembly.dir}"> > <fileset dir="${basedir}"> > <include name="build.properties"/> > <include name="project.xsd"/> > </fileset> > </copy> > > </postGoal> > Regards, > Davy Toch -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
