Brett, I'm switching this to the DEV list; Rod and I had a few problems. I'm attaching a diff.txt file of the changes made to the maven-compiler-plugin. We also made some changes as you predicted to the plexus-compiler-api and plexus-compiler-javac modules. We were not able to successfully use CVS or SVN to checkout any projects from the Plexus project. So we used ViewCVS to navigate to each individual file and save each file off locally. This is why the diff.txt file only includes the changes made to the Maven module.
We think we're on the right track with the changes made thus far. Please help us out by letting us know: - How to checkout the Plexus modules. - What else is required in order to submit patches once we are able to successfully check all necessary modules out. - Are we on the right track with this change. Please review the attached ZIP file and let us know if we are going down the recommended path, and what you see that is left in order to wrap this change up and get it in the build. I look forward to your feedback. I hope this MOD will help others as well. Thanks, Derek---- [EMAIL PROTECTED] On 8/4/05, Brett Porter <[EMAIL PROTECTED]> wrote: > Great! It is definitely similar to the other issue, but in a different place. > > The areas you'll need to add configuration are: > http://svn.apache.org/viewcvs.cgi/maven/components/trunk/maven-plugins/maven-compiler-plugin/ > > The forking needs to be added to the plexus-compiler-javac module: > http://cvs.plexus.codehaus.org/trunk/plexus-components/plexus-compiler/plexus-compilers/plexus-compiler-javac/ > > The original Maven 1 plugin: > http://svn.apache.org/viewcvs.cgi/maven/maven-1/plugins/trunk/java/plugin.jelly > > Hope this helps get started. Hopefully you will find it fairly > straightforward. There isn't much code to wade through here. > > You can use the Commandline class in plexus-utils to execute the Java > process for now. You can find examples of its use all through the m2 > code: in particular, take a look at the maven-core-it-verifier. > > Cheers, > Brett > > On 8/5/05, Derek Lane <[EMAIL PROTECTED]> wrote: > > Yes, that was the breakdown I was looking for. Your thread w/ Rod seems to > > be > > needing a similar solution. Rod and I can try to work together to > > tackle this if you > > really think it's about a day's effort -- of course I realize that's a > > day for you given > > your familiarity w/ the M2 codebase. > > > > Can you point us in the right direction? We will be glad to follow > > your pin-point instructions > > to make the changes. Seriously, the more details you can provide the > > less time it will take > > us to get oriented since I'm not familiar with the Maven codebase at all. > > > > Looking forward to helping if we can. > > Thanks, Derek > > > > > > On 8/4/05, Brett Porter <[EMAIL PROTECTED]> wrote: > > > On 8/5/05, Derek Lane <[EMAIL PROTECTED]> wrote: > > > > So what I hear you saying now, is that I won't be able to use M2 until > > > > the compiler forking > > > > feature is added. Bummer. > > > > > > Sorry to say it does appear that way, if you are to use it out of the box. > > > > > > > I was really hoping to avoid converting this codebase to M1, only to > > > > have to conver the > > > > build again to M2 soon thereafter. Please tell me if I've missed what > > > > you are saying and > > > > let me know what options I have for resolving this with the current > > > > alpha-3 M2 release. > > > > > > The following options are available: > > > - wait until the compiler plugin has this feature (I would say some > > > time this month) > > > - implement the feature in the compiler plugin and contribute it back > > > (I'd estimate this is less than a day's work) > > > - use the ant run plugin to compile the sources using an the Ant javac > > > task (see the FAQ on the website) > > > > > > Hope this helps. > > > > > > - Brett --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
