[ http://jira.codehaus.org/browse/MNG-710?page=comments#action_44180 ] 

Trygve Laugstol commented on MNG-710:
-------------------------------------

No, no problem, I'll fix it. It's not a big deal, it just makes it harder to 
see what you've really changed.

Anyway, from what I can tell this won't work with a jdk1.4+ external compiler. 
I think we need to add a "compiler version" parameter here so the compiler 
component can know how and when to specify the different -source and -target 
parameters. I've made the methods for building the argument lists public and 
static to make them easier to test so I'd like you to make some tests for this 
aswell. Just makes it ieasier for me and the next guy that has to maintain the 
component to understand the requirements.

> Add ability to fork the maven-compiler-plugin
> ---------------------------------------------
>
>          Key: MNG-710
>          URL: http://jira.codehaus.org/browse/MNG-710
>      Project: Maven 2
>         Type: Improvement
>   Components: maven-plugins
>     Reporter: Rod Coffin
>     Assignee: Trygve Laugstol
>      Fix For: 2.0-beta-1
>  Attachments: maven-compiler-plugin.diff.txt, plexus-compiler-api.diff.txt, 
> plexus-compiler-javac.diff.txt, plexus-compiler-javac.diff2.txt
>
>
> Add the ability to fork the maven-compiler-plugin.  This would allow projects 
> to be compiled with a JDK other than the one used to run Maven from.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to