Phil Steitz wrote:
>
> I am happy to patch both plugins to remove the trailing "/", but I
> think it would be better to encapsulate the code that computes
> ${scmConnection} in both plugins and I frankly don't know how to do
> that correctly in Jelly. There is a goal in the scm plugin called
> "scm:find-connection" that sets the *local* variable scmConnection.
> The right thing to do is to patch that code and then somehow allow the
> jdiff plugin to use the same goal and share the property. Is this
> possible?
>
The ultimate solution is to push all of the relevant code into maven-scm
(which the SCM plugin uses) and have both use that. It shouldn't
interact with a Maven project but should be able to do the URL
validation with the one it is given. In general, this would be the
preferred way (shared Java code), and is basically what we are pushing
towards as we try and get the m2 plugins working in m1 to have a single
code base.
However, given that direction, a quick fix is just fine. I'd suggest
changing the code in both plugins for now.
- Brett
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
