maven.dashboard.report.showempty property not honoured when using Maven 1.1b1
-----------------------------------------------------------------------------

         Key: MPDASHBOARD-32
         URL: http://jira.codehaus.org/browse/MPDASHBOARD-32
     Project: maven-dashboard-plugin
        Type: Bug
    Versions: 1.8    
 Environment: Maven 1.1beta1
Windows XP
 Reporter: Wim Deblauwe


When using the 'maven.dashboard.report.showempty' property, the dashboard 
overview still shows the empty reports. The problem seems to be with the 
isEmpty() call.

The orginal code is like this (in dashboard.jsl):

    <!-- Decide whether to display project data -->
    <j:set var="shallDisplay" value="true"/>
    <j:if test="${context.getVariable('maven.dashboard.report.showempty') == 
'false'}">
      <x:set var="notEmptyElems" select="aggregator[not(text() = '-')]"/>
      <j:if test="${notEmptyElems.isEmpty() == 'true'}">
        <j:set var="shallDisplay" value="false"/>
      </j:if>
    </j:if>

It should be changed to this:

    <!-- Decide whether to display project data -->
    <j:set var="shallDisplay" value="true"/>
    <j:if test="${context.getVariable('maven.dashboard.report.showempty') == 
'false'}">
      <x:set var="notEmptyElems" select="aggregator[not(text() = '-')]"/>
      <j:if test="${empty(notEmptyElems)}">    <!-- THIS LINE CHANGED -->
        <j:set var="shallDisplay" value="false"/>
      </j:if>
    </j:if>

I tested this and it works fine with my little change.

regards,

Wim

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to