[ http://jira.codehaus.org/browse/MNG-760?page=comments#action_46126 ]
Kenney Westerhof commented on MNG-760: -------------------------------------- Hi Fabrizio, Thanks for all your hard work. Usually we recommend to only modify the lines affected by your change. That makes the diff easier to read. Also, adding new features and doing refactoring at the same time is discouraged, but I know that these usually go hand in hand. Anyway, I've tried to apply the patch but no go. Not sure if it's my version of patch (2.5.9), or your svn client. There where ^M all over the file, and you should have file endings set to native in svn. Also, the new files didn't get created; i had to touch them, and then i got errors like these: $ patch -p3 < ~/MNG-760-2.diff patching file src/main/java/org/apache/maven/plugin/eclipse/EclipseClasspathWriter.java patch: **** malformed patch at line 264: So, i was wondering if you could just attach a zipped/tar.gz version of your maven-eclipse-plugin dir this time..? > m2 eclipse plugin improvements (source download and attachment, customization > of natures/builders/conclasspath, flexible project dupport) and refactoring > --------------------------------------------------------------------------------------------------------------------------------------------------------- > > Key: MNG-760 > URL: http://jira.codehaus.org/browse/MNG-760 > Project: Maven 2 > Type: Improvement > Components: maven-plugins > Versions: 2.0-beta-1 > Reporter: fabrizio giustina > Assignee: Kenney Westerhof > Fix For: 2.0-beta-2 > Attachments: MNG-760-1.diff, MNG-760-2.diff, MNG-760.diff > > > This patch adds the following to the M2 eclipse plugin: > - downloading of source attachments and configuration in .classpath > - customization of project builders and natures in .project (like in the m1 > plugin) > - additional conclasspath entries in .classpath (like in the m1 plugin) > - fix: don't add duplicate directories if main/resources directories overlap > (like in the m1 plugin) > - support for flexible projects (.wtpmodules file generation for utility > modules, wars, ejbs) > Along with these new features the plugin has been refactored, splitting the > single big EclipseWriter class to several specific classes and all the > messages have been externalized in a property file. > There are still some todos in the code, which probably some M2 guru could > look at, but anyway all the existing functionalities continue to work and > some other tests have been added. > Due to the refactoring the patch looks more like a complete rewrite: sorry > for that, but adding new features without splitting the existing file was ugly -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
