-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Basically, there was a problem with the release plugin, wherein a profile with an empty resources list was overriding the default resources list from the super-POM. It's not really another use case for the merge vs. override discussion, but it did highlight part of the resource handling during profile injection, which is why I referred it to 895. To fix this bug, I just put in a piece of code to check whether the profile's resources list is empty (in addition to a null check) before it overrode the model resources. I haven't addressed the override vs. merge topic yet.
Sorry for the false alarm! :) - -john P.S. My personal view on this is that profiles are meant primarily for augmentation, and secondarily for overriding...this would lead me to conclude that resource lists should be merged wherever the resource keys don't conflict (what's the key for a resource? probably it's dir). That's the way I'm leaning for implementing/fixing 895, but I'd like to solicit as much feedback as I can. -J Mark Hobson wrote: | [moving to dev as suggested] | | I see MNG-881was closed that depended on this (MNG-895) feature. Does | this mean we have another use-case for this? If so, what is it | briefly? It'd be good to discuss whether overriding or inheriting is | the correct behaviour for resources. | | Mark | | On 15/09/05, Brett Porter <[EMAIL PROTECTED]> wrote: | |>DefaultModelInheritenceAssembler. |> |>Merged: |>- dependencies |>- developers and contributors |>- plugin lists (including reports) |>- plugin executions with matching ids |>- plugin configuration |> |>Cheers, |> Brett |> |> |>On 9/15/05, Mark Hobson <[EMAIL PROTECTED]> wrote: |> |>>On 15/09/05, Brett Porter <[EMAIL PROTECTED]> wrote: |>> |>>>Hi Mark, |>>> |>>>This is by design. For simplicity, it is intended that profiles behave |>>>identically to inheritence, and inheritence doesn't merge resource sets. |>>>This may or may not be the right behaviour though - but we should |> |>discuss in |> |>>>that context rather than the profile. |>> |>>Where's the definitive list of POM elements that get inherited or |>>overridden? Source or doc is fine. Not entirely sure which way is |>>the right one, maybe both are under different circumstances, but I'm |>>sure you guys trashed this one out in the confluence design docs. |>> |>>Mark |>> |> |> | | --------------------------------------------------------------------- | To unsubscribe, e-mail: [EMAIL PROTECTED] | For additional commands, e-mail: [EMAIL PROTECTED] | | | -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.6 (GNU/Linux) iD8DBQFDKxsgK3h2CZwO/4URAssWAJ96X/G7JGj4Vey0Tm+a13ieHhTUhwCglL1X FyZzxoWDXMK7DVhJQn6qeAw= =RBxg -----END PGP SIGNATURE----- --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
