[ http://jira.codehaus.org/browse/MNG-1037?page=comments#action_47953 ] 

Kenney Westerhof commented on MNG-1037:
---------------------------------------

Hi Allan,

Nice patch, except for the solution. I guess you don't know this, but if you 
have 2 classes in a plugin, 
and one extends the other, both can have /** @parameter */ annotations - that 
works even for abstract
base classes.

I suggest you create an AbstractWarMojo baseclass, move all the common code 
(including setters/getters/fields/@parameter annotations)
there, and let the mojo's extend that common baseclass. 

That way the 3 mojo's will be very small and will be more maintainable - f.i. 
adding a parameter now has impact at 3 classes,
when you use the abstract base class there's just one class to modify, etc..

Thanks a lot!

> Add war:exploded and war:inplace goals
> --------------------------------------
>
>          Key: MNG-1037
>          URL: http://jira.codehaus.org/browse/MNG-1037
>      Project: Maven 2
>         Type: Improvement
>   Components: maven-war-plugin
>     Versions: 2.0-beta-2
>     Reporter: Mark Hobson
>     Assignee: allan ramirez
>      Fix For: 2.0-beta-4
>  Attachments: MNG-1037.patch
>
> Original Estimate: 8 hours
>        Time Spent: 8 hours
>         Remaining: 0 minutes
>
> Need to add war:exploded and war:inplace goals to replace the depreciated 
> war:war mode config parameter.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to