[ http://jira.codehaus.org/browse/MNG-1174?page=comments#action_48421 ] 

Bob Allison commented on MNG-1174:
----------------------------------

Holding off is not a problem.

I had started to try to build this as a separate plugin that leveraged off of 
the compiler plugin code.  Although I could build the plugin with the compiler 
plugin as a compile dependency, when I tried to use the plugin it failed 
miserably because the parameters defined in AbstractCompilerMojo were not 
included in the plugin descriptor (and editing the file didn't help since the 
descriptor was rewritten the next time I tried to package the plugin even 
though nothing else had changed).

I'm sure this needs some close review since I just did a simple copy with a 
couple hacks.  There are probably a few things I copied that make it work wrong 
in some (or most) circumstances.  I'm especially unsure about the reference to 
"Artifact" in the compiler mojo and if I should have taken that out.

One thing that might eliminate the need for these mojos is if the 
"compileSourceRoots" and "outputDirectory" parameters were made editable.  I 
very much understand why they are read only, since you want the default 
behavior driven from the POM correctly.  Perhaps it might be possible to have 
these appear twice: one copy is defined editable with no defaults but not 
marked required, the other copy (with "Pom" on the end) defined as they are 
now.  The plugin could then use the POM-based variables if the user did not 
specify the editable parameters and fail if the user only specifies one of the 
editable parameters.  (Just a thought...)

> New Mojos for compiler and jar plugins to allow alternate jars
> --------------------------------------------------------------
>
>          Key: MNG-1174
>          URL: http://jira.codehaus.org/browse/MNG-1174
>      Project: Maven 2
>         Type: Improvement
>     Versions: 2.0-beta-3
>  Environment: Linux using JDK 1.5.0_01
>     Reporter: Bob Allison
>      Fix For: 2.0-beta-4
>  Attachments: AltCompilerMojo.java, AltJarMojo.java, pom.xml
>
>
> Add mojos so that mock objects and other affiliated source roots can be 
> compiled and packaged in the same project

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to