[ http://jira.codehaus.org/browse/MNG-1113?page=comments#action_49779 ] 

David Parry commented on MNG-1113:
----------------------------------

But it's not a "Properties" file that's needed here, it's the Checkstyle XML 
configuration file, which contains XML, not key-value pairs.

Either this needs to be renamed (to configFile or similar), or you're talking 
about the wrong thing.

The default configuration files, (e.g. "sun") have some quite wrong-headed 
settings in them that are just plain wrong in certain circumstances. For 
instance, it checks for trailing white spaces on blank lines... yet, my 
editor's auto-indenting works by inserting spaces to the current indent level, 
regardless of whether it's a blank line or not. A lot of editors behave this 
way. Trying to run Checkstyle over my otherwise-checkstyle-correct code with 
this setting on produces 1000s of errors.

And, as Dave Sag mentions, requesting Javadoc comments for private fields is 
crazy overkill.

So, we need to have a custom configuration. Can i assume that there is NO WAY 
to do this at the moment?


> Plugin does not support using custom checkstyle XML config file
> ---------------------------------------------------------------
>
>          Key: MNG-1113
>          URL: http://jira.codehaus.org/browse/MNG-1113
>      Project: Maven 2
>         Type: Bug
>   Components: maven-checkstyle-plugin
>     Versions: 2.0-beta-3
>     Reporter: Vincent Massol
>     Assignee: Edwin Punzalan
>  Attachments: MNG-1113-maven-checkstyle-plugin.patch, recommended.txt
>
>
> The plugin source code says:
>     /**
>      * Specifies the location of the checkstyle properties that will be used 
> to check the source.
>      *
>      * @parameter
>      */
>     private File propertiesFile;
> But in practice it's only loading *properties* and not the XML. The 
> getConfigFile() method is not right and needs to be modified to take into 
> account a custom checkstyle config file.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to