[ http://jira.codehaus.org/browse/MNG-1251?page=all ]
     
John Casey closed MNG-1251:
---------------------------

    Resolution: Fixed

patch was reviewed but not applied. The better approach was to make the 
attached artifact more independent, only delegating the identity-related fields 
(groupId, artifactId, version stuff) to the main artifact. The only reason to 
do this is to keep metadata lookups working consistently based on this info.

Also, I added code to MavenProjectHelper to lookup and pass on the correct 
ArtifactHandler for the given artifact type used for the attachment.

Thanks for the help on running this one down, Jerome (and everyone else who 
helped). 

> attachArtifact doesn't allow to attach an artifact with different type and no 
> assembly
> --------------------------------------------------------------------------------------
>
>          Key: MNG-1251
>          URL: http://jira.codehaus.org/browse/MNG-1251
>      Project: Maven 2
>         Type: Bug
>   Components: maven-project
>     Versions: 2.0
>     Reporter: Jerome Lacoste
>     Assignee: John Casey
>     Priority: Blocker
>      Fix For: 2.0.1
>  Attachments: MNG-1251_more_flexible_attach_artifact.diff
>
> Original Estimate: 1 hour
>        Time Spent: 1 hour
>         Remaining: 1 hour
>
> Use case: a project triggers a plugin which generates several files. I want 
> to put all these files in a zip file and install it when calling install.
> So I bind my plugin to the package phase, I keep the project packaging as 
> pom, and then i tri to do soemthing like projectHelper.attachArtifact( 
> project, "zip", null, toFile ); in my execute() method
> this fails in 2 places:
> - empty or null classifier is disallowed by AttachedArtifact
> - then AttachedArtifact inherits the parent's ArtifactHandler which then will 
> return "pom" as extension instead of "zip" (the type) .
> Thus my artifact ends up being installed in finalName-forcedClassifier.pom 
> instead of finalName.zip...
> Blocks my webstart plugin development,
> Note that project.attachArtifact() looks empty...

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to