[ http://jira.codehaus.org/browse/MNG-1430?page=comments#action_50315 ] 

Dan Allen commented on MNG-1430:
--------------------------------

I don't believe that the plugin should leave out the project natures and 
builders simply because they *might* change.  What is to say that the natures 
and builders for the JDT (java) eclipse plugin won't change?  If they DO happen 
to change, then we simply update the maven eclipse plugin to include them.

About users' choice for "other web application plugins", I think it is safe to 
say that moving forrward, most people are moving to the WTP engine (in this 
case 0.71).  Sure, there will be people not using it, but it will be a far 
smaller number and those people could potentially create their own maven plugin 
(or modification).  Perhaps there could be an override property in the plugin 
configuration to NOT use WTP builders and natures (and perhaps we maintain a 
set).

So namely we are talking about *good* defaults.  Maven is all about *good* 
defaults, so I say that if users complain, we simply add more overrides, but 
certainly don't hold back on making it work for a majority of users.  Right 
now, exactly NO web application plugins for eclipse are supported.  We generate 
a .wtpmodules file, but it is worthless without the proper .project 
configuration.

> add j2ee project nature/builders to generated .project file
> -----------------------------------------------------------
>
>          Key: MNG-1430
>          URL: http://jira.codehaus.org/browse/MNG-1430
>      Project: Maven 2
>         Type: Improvement
>   Components: maven-eclipse-plugin
>     Versions: 2.0
>  Environment: maven 2.0 on linux
>     Reporter: Dan Allen
>  Attachments: MNG-1430.txt
>
>
> When the eclipse:eclipse target generates the .project file for a war project 
> in maven, the .project file contains only the natures and builders for a 
> regular java project.  The additional information is as follows for WTP 0.71
>           <buildCommand>
>               
> <name>org.eclipse.wst.common.modulecore.ComponentStructuralBuilder</name>
>               <arguments>
>               </arguments>
>           </buildCommand>
>           <buildCommand>
>           <buildCommand>
>               <name>org.eclipse.wst.validation.validationbuilder</name>
>               <arguments>
>               </arguments>
>           </buildCommand>
>           <buildCommand>
>               
> <name>org.eclipse.wst.common.modulecore.ComponentStructuralBuilderDependen    
>           <arguments>
>               </arguments>
>           </buildCommand>
>           <buildCommand>
>               
> <name>org.eclipse.wst.common.modulecore.DependencyGraphBuilder</name>
>               <arguments>
>               </arguments>
>           </buildCommand>
>          <nature>org.eclipse.jem.workbench.JavaEMFNature</nature>
>          <nature>org.eclipse.wst.common.modulecore.ModuleCoreNature</nature>

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to