[ http://jira.codehaus.org/browse/MNG-1038?page=comments#action_50686 ]
Niklas Ekman commented on MNG-1038: ----------------------------------- I read the documentation on the war plugin (http://maven.apache.org/plugins/maven-war-plugin/war-mojo.html) and it should be possible to send in a comma separated list of excludes. I looked into the source but couldn't find anything that can make this work, so I think this is bug. The code below depends on the commons StringUtils helper class. protected String[] getExcludes() { List excludeList = new ArrayList( FileUtils.getDefaultExcludesAsList() ); if ( warSourceExcludes != null && !"".equals( warSourceExcludes ) ) { String[] excludes = StringUtils.split(warSourceExcludes, ","); for (int i = 0; i < excludes.length; i++) { String exclude = excludes[i]; excludeList.add( exclude ); } } // if webXML is specified, omit the one in the source directory if ( getWebXml() != null && !"".equals( getWebXml() ) ) { excludeList.add( "**/" + WEB_INF + "/web.xml" ); } return (String[]) excludeList.toArray( EMPTY_STRING_ARRAY ); } I haven't written a testcase or even tested the code, but I want to verify if I've understood the function right. > warSourceExcludes not working properly > -------------------------------------- > > Key: MNG-1038 > URL: http://jira.codehaus.org/browse/MNG-1038 > Project: Maven 2 > Type: Bug > Components: maven-war-plugin > Versions: 2.0-beta-1 > Environment: Win2k, Java 1.4.2_04, m2 beta1 > Reporter: Fabrice BELLINGARD > Assignee: Edwin Punzalan > Fix For: 2.0.1 > Attachments: MNG-1038-maven-war-plugin.patch, MNG-1038-maven-war-plugin.patch > > > Note: I posted a message on Maven users list > (http://www.mail-archive.com/users%40maven.apache.org/msg24088.html), but I > got no answer so I post this issue, which in turn may or not be a bug... > (sorry if it's not) > I experienced a strange behaviour with the 'warSourceExcludes' property. When > I grab some Web projects from the CVS of my company, I usually get all the > WEB-INF/lib Jars that the developers put in the CVS: > - With Maven 1, I use the 'maven.war.src.excludes' property to exclude those > Jars ('maven.war.src.excludes=**/lib/*.*'), and it works well: the Jars > packaged in the War are only the ones defined in the pom. > - With m2, I tried to use the 'warSourceExcludes' property, which seemed to > me to be the equivalent property. However, when the War is generated, there > is no jar in the WEB-INF/lib folder. This works as if the plugin is excluding > files after having copied the needed dependencies in the WEB-INF/lib folder > (whereas in the Maven 1 version, it was excluding them before). > Looking at the code of the m2 plugin, the value of 'warSourceExcludes' is > used in method #getExcludes which is actually called in #performPackaging > method. If this property is to work the same way as in m1, its value should > be used in #copyResources method, before copying the Jar dependencies in > WEB-INF/lib. > What do you guys think of that? Am I right or am I missing something? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
