[ http://jira.codehaus.org/browse/MNG-1113?page=all ]
Joakim Erdfelt updated MNG-1113:
--------------------------------
Attachment: checkstyle-config-location-and-docs.tar.bz2
(re: checkstyle-config-location-and-docs.tar.bz2)
I promised brett I would submit this patch (first mentioned in #maven).
This patch does a few things.
* Allows custom checker configurations to work.
* Allows custom checker modules to work.
* Allows for multi-module plugin configuration to work.
* Properly documents the property expansion mechanism in checkstyle and how it
relates to this plugin.
* Condenses / Simplifies configuration options to be more reasonable.
* Increases the ability to find the configuration information. (URL / File /
Resource supported).
Included in this tarball is the patch against the codebase and a sample static
site (html) that can be viewed to see what the configuration and docs look like
(before you apply the patch).
The patch:
* modifies the CheckstyleReport.java
* adds a Locator.java
* adds customize.apt
* adds tips.apt
* modifies the sample-checkstyle.html
What is not included:
* Code on my side that performs a merge of configurations and properties to
allow for heirarchical checker configurations.
* CheckstyleCheckerReport that produces a report showing what rules are
actively being checked for, and how many violations of each occured during the
checkstyle run.
> Plugin does not support using custom checkstyle XML config file
> ---------------------------------------------------------------
>
> Key: MNG-1113
> URL: http://jira.codehaus.org/browse/MNG-1113
> Project: Maven 2
> Type: Bug
> Components: maven-checkstyle-plugin
> Versions: 2.0-beta-3
> Reporter: Vincent Massol
> Assignee: John Casey
> Attachments: CheckstyleReport.java, MNG-1113-maven-checkstyle-plugin.patch,
> checkstyle-config-file.patch, checkstyle-config-location-and-docs.tar.bz2,
> recommended.txt
>
>
> The plugin source code says:
> /**
> * Specifies the location of the checkstyle properties that will be used
> to check the source.
> *
> * @parameter
> */
> private File propertiesFile;
> But in practice it's only loading *properties* and not the XML. The
> getConfigFile() method is not right and needs to be modified to take into
> account a custom checkstyle config file.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
