Hi Emmanuel,
Understood. I'll open a JIRA issue for this and assign it to myself.
Breakdown of tasks:
- move code from
org.apache.maven.continuum.build.settings.DefaultSchedulesActivator to
plexus-quartz
- transform
org.apache.maven.continuum.web.validation.CronExpressionValidator into a
POJO
Will submit the patch later.
Thanks,
John
Emmanuel Venisse wrote:
Hi john,
I'm totally agree to factoring this code.
We can use the plexus-quartz component, but i want it use continuum
code (similar code but with more methods like unschedule job and it
was more tested)
We can perhaps put in plexus-quartz some code from
org.apache.maven.continuum.build.settings.DefaultSchedulesActivator
and the cron expression validator
org.apache.maven.continuum.web.validation.CronExpressionValidator
transformed in a POJO
We have some code too in org.apache.maven.continuum.DefaultContinuum :
public void addSchedule( Schedule schedule )
private void updateSchedule( Schedule schedule, boolean updateScheduler )
but i don't think we can factorize it.
Emmanuel
John Tolentino a écrit :
Hi,
I've seen reusable code in both Plexus and Continuum. The following
have similar code:
org.apache.maven.continuum.scheduler.ContinuumScheduler
org.apache.maven.continuum.scheduler.DefaultContinuumScheduler
org.codehaus.plexus.scheduler.DefaultScheduler
org.codehaus.plexus.scheduler.Scheduler
Can we factor this out to task-scheduler? I'll also use the code to
resolve MRM-38. It would make more sense if the code appears in just
one place instead of three.
Thanks,
John
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
