[ http://jira.codehaus.org/browse/MECLIPSE-47?page=comments#action_54327 ]
fabrizio giustina commented on MECLIPSE-47: ------------------------------------------- Patch committed to svn, with a few changes. R7 is left as the default since there are some left for wtp 1.0, see the following comments. > 1) Plugin now generates WTP settings only if packaging was set to WAR or EAR. this broke the wtp 0.7 support! The .wtpmodules file is required also for utility projects. I am not sue if this is required for 1.0 too, at the moment I re-enabled it only for R7, we will need to check it > 4) Project sanity is now validated before defaults (Default Natures, > Builders, classpath containers) are generated by EclipsePlugin. be careful, the order of project builders/natures is really important, the previous order has been restored > 6) PATCH for WTP1.0 bug: good, but it should be made optional, maybe we could start defining a 1.0.1 WTP version and enable/disable the workaround based on the version > 7) Fixed Unit Tests. Note that these still run for R7. ok, now they are fixed, but don't change the expected result (see 1 and 4) if you are not absolutely sure the previous result was wrong. What is missing before enabling wtp 1.0 support by default: - unit tests for wtp 1.0 should be added. All the existing unit tests have been set to use R7 - the wtp settings writer writes the wrong version for java (it was always set to 5.0, now I changed it to 1.4), servlet, and j2ee. It should use the java version defined in pom.xml and the servlet version extracted from dependencies (the settings/WtpModules writers already do that). ... and a few additional notes: - please use the provided eclipse formatter configuration, your patch had a lot of formatting changes which make it harder to read and to apply - log messages should be externalized (see the existing code), and NLS markers should be set properly I am leaving the issue open till everything is resolved. thanks for the help Rahul! > Planning support for wtp 1.0 > ---------------------------- > > Key: MECLIPSE-47 > URL: http://jira.codehaus.org/browse/MECLIPSE-47 > Project: Maven 2.x Eclipse Plugin > Type: Bug > Versions: 2.0 > Reporter: fabrizio giustina > Priority: Minor > Attachments: MECLIPSE-47.patch > > > while approaching the 1.0 release WTP changed completely the project > descriptors for modules. > The eclipse plugin should let users choose the version of WTP and generate > different files (wtp will anyway automatically migrate 0.7 projects starting > from M9, according to eclipse plans) > Changes tracked for wtp 1.0 (partially working in current WTP builds): > - ".wtpmodules" is renamed to ".component" and moved to the .settings folder > - the .wtpmodules format is unchanged, except for the module type which is > not there anymore (should be verified in M9) > - a new .settings/org.eclipse.wst.common.project.facet.core.prefs file is > written (property file) with server/module type information (server is now > specified in containerClasspath, need to be fixed) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
