[ http://jira.codehaus.org/browse/MPMD-4?page=comments#action_55258 ] 

John Allen commented on MPMD-4:
-------------------------------

Over the weekend i took this code and MPMD-8 patches and went through the 
pmd:pmd and pmd:execute Mojos refactoring and aligning them with the other 
report and analysis plugins I use (checkstyle, coberutra, pmd)

I would like to suggest that  the ruleSets config approach is adopted for both 
Mojos but modified to use the Locator lifted from checkstyle (MPMD-4) so that 
one is able to specify any number of rulesets, either from the pmd Jar or 
custom ones.

My current impl of both the pmd:pmd report Mojo and the pmd:execute Mojo are 
configured thus:

                                <configuration>
                                        <ruleSets>
                                                <ruleSet>D:\mine.xml</ruleSet>  
                                        
                                                
<ruleSet>http:///localhost/basic.xml</ruleSet>
                                                
<ruleSet>/rulesets/basic.xml</ruleSet>
                                                
<ruleSet>/rulesets/controversial.xml</ruleSet>
                                        </ruleSets>
                                </configuration>

Additionally I took the external report generation functionality from the 
execute mojo and added it to the report mojo. This is useful for integrating 
the output into other tools (CC, QALab) as perviously stated although i made it 
optional as the real item of interst is the generated site/pmd.html file.

I would like to respectfully ask that these changes be applied to your efforts 
before this plugin is released as its trivial to do and provides greater 
flexibility as well as functionality.

Note I can supply my code but as the plugin is trivial there doesnt seem much 
point.




> PMD should use "sensible" default rulesets
> ------------------------------------------
>
>          Key: MPMD-4
>          URL: http://jira.codehaus.org/browse/MPMD-4
>      Project: Maven 2.x Pmd Plugin
>         Type: Task

>     Reporter: Dave Sag
>  Attachments: Locator.java, MNG-1158-maven-pmd-plugin.patch, 
> PmdReport.java.diff
>
>
> When I add a PMD report to my pom.xml the PMD report claims that my class 
> 'Address' should have a constructor.
> this is crazy talk - Address.java is an interface class.
> i guess this is really a PMD bug but i find it hard to believe that such a 
> well established tool as PMD would still be throwing up bugs like this.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to