Actually, one of the problems, the most pressing one, was introduced by his patch:

-                clFactoryClass =
-                    (String) FACTORIES.get( connection.substring( 4, 7 ) );
+                int iProviderEnd = connection.indexOf( ":", 4 );
+                if ( iProviderEnd == -1 )
+                {
+                    // Connection = scm:<provider>
+                    iProviderEnd = connection.length();
+                }
+
+ clFactoryClass = (String) FACTORIES.get( connection.substring( 4, iProviderEnd ) );


I'll supply a patch for this tomorrow.
Should I put it in JIRA?

--
Dennis Lundberg


Lukas Theussl wrote:
Dennis,

You are right, but this is not a bug introduced by the current patch which deals with a different issue. The ':' was there before already, this should be corrected separately and consistently (I haven't checked where else the colon is hardcoded). Want to submit a patch? :)

-Lukas


Dennis Lundberg wrote:
This change does not work if the scm url is using "|" as separator instead of ":". See more below...


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]





---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to