[ http://jira.codehaus.org/browse/MNG-1181?page=comments#action_59900 ]
Jason van Zyl commented on MNG-1181: ------------------------------------ You will want to take a look here: http://svn.apache.org/viewcvs.cgi/maven/components/branches/maven-embedder-refactor/ The MavenCli class now uses the embedder and I've pushed a lot of the code that was in the MavenCli class into DefaultMaven. Many of your points there have been addressed and next week I'll be actively working on this code so we probably need to exchange some email or chat on IRC if you want to do some work that I will incorporate. I'm not sure if you are subscribed to the dev mailing list but I will be sending a message there talking about incorporating what is on the branch into the trunk. Now to address your points above: - Everything that goes into DefaultMaven should be couched in terms of the MavenExecutionRequest. Internally Maven should deal with a MavenExecutionRequest and the MavenSession. Anything that comes in via the CLI should be translated into a request and the Settings object that is used throughout the core should be taken out of the core. - I've has started figuring out what is required per request to make sure that the embedder works in a multi threaded environment. So this you could certainly help me with. The embedder is pretty chopped up on the branch but you can see how the embedder is being using in the MavenCli class in the branch. - I would be happy to work with you to figure out how to best configure the embedder. - This I've done by allowing the configuration of the request itself. You can see exactly what's happening by looking at the MavenCli in the branch. - I think what I've started is heading down that path. - No patch is ever going to be accepted unless we are actually in discussion on a regular basis. That's how I can guide you, with some dialog. - This has been done on the branch. - Same as above regarding integrating large patches/changes. - This has been done on the branch. Everyday this week and on the weekend I'll be doing some work on the embedder to prepare for a presentation on the 7th of March. > MavenEmbedder.execute() doesn't run reactor modules > --------------------------------------------------- > > Key: MNG-1181 > URL: http://jira.codehaus.org/browse/MNG-1181 > Project: Maven 2 > Type: Bug > Components: Embedding > Reporter: Eugene Kuleshov > Priority: Blocker > Fix For: 2.0.4 > Attachments: MNG-1181.tar.gz, MavenEmbedder2.java, MavenEmbedder2.java > > > MavenEmbedder.execute() doesn't run reactor modules. > I've been trying to run it with "generate-sources" goal, but it only build > the root project. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
