[ http://jira.codehaus.org/browse/MNG-2127?page=comments#action_60316 ]
Wayne Fay commented on MNG-2127: -------------------------------- Any particular reason this isn't ON by default? It makes no sense to me that this needs to be turned ON when it seems like normal behavoir for commandline utilities in any Operating system. But there is probably a good reason why this is off for Windows, and I just don't know enough to realize why... > mvn.bat always exits 0 on Windows 2000 and higher > ------------------------------------------------- > > Key: MNG-2127 > URL: http://jira.codehaus.org/browse/MNG-2127 > Project: Maven 2 > Type: Bug > Components: Command Line > Versions: 2.0, 2.0.1, 2.0.2 > Environment: I'm on Windows 2003 Server, but this will affect any OS for > which the %OS% environment variable is Windows_NT, including Windows XP and > Windows 2000. > Reporter: Dan Fabulich > Priority: Blocker > > > Write the following ant script and run it on Windows 2000 or higher: > <project default="main"><target name="main"><exec executable="mvn.bat" > failonerror="true" /></target></project> > This will run "mvn" with no arguments, which will always fail. But the ant > script will claim "build successful", because the exit value of mvn.bat was > 0. It is absolutely critical that this work correctly, or else I can't > integrate Maven into any other automated system. > This is happening because mvn.bat is improperly abusing local scoping. On > line 130 of mvn.bat, we execute maven, but we don't do anything with its exit > value... we just always goto end. The fix for this is to add a line 131 that > says "if errorlevel 1 goto error", which will behave correctly. > (I marked this as having a test case because I've included a test ant script, > but technically this isn't a JUnit test case, so it may be an inappropriate > use of the "testcase included" marker.) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
