It still works, but before it was wrong. Before, say you ran: mvn insllat mvn install
the second one would fail because ERROR_CODE is still 1 from the first time. See my comments on MNG-2127. You're assessment was right in the first place, but I think if we change plexus-utils to always run: "CMD.EXE /C call " + args instead of "CMD.EXE /C " + args The terminate command is no longer needed and we can rely on exit /b BTW, it has an /X in there too, but that seems to be an undocumented argument, and I can't find out what it does. Cheers, Brett Emmanuel Venisse wrote: > Why do you do this? it worked well without this change. > > Emmanuel > > [EMAIL PROTECTED] a écrit : >> Author: brett >> Date: Wed Mar 8 05:05:43 2006 >> New Revision: 384207 >> >> URL: http://svn.apache.org/viewcvs?rev=384207&view=rev >> Log: >> fix location of original setter >> >> Modified: >> maven/components/branches/maven-2.0.x/maven-core/src/bin/mvn.bat >> >> Modified: >> maven/components/branches/maven-2.0.x/maven-core/src/bin/mvn.bat >> URL: >> http://svn.apache.org/viewcvs/maven/components/branches/maven-2.0.x/maven-core/src/bin/mvn.bat?rev=384207&r1=384206&r2=384207&view=diff >> >> ============================================================================== >> >> --- maven/components/branches/maven-2.0.x/maven-core/src/bin/mvn.bat >> (original) >> +++ maven/components/branches/maven-2.0.x/maven-core/src/bin/mvn.bat >> Wed Mar 8 05:05:43 2006 >> @@ -38,10 +38,10 @@ >> @REM Execute a user defined script before this one >> if exist "%HOME%\mavenrc_pre.bat" call "%HOME%\mavenrc_pre.bat" >> >> +set ERROR_CODE=0 >> + >> @REM set local scope for the variables with windows NT shell >> if "%OS%"=="Windows_NT" @setlocal >> - >> -set ERROR_CODE=0 >> >> @REM ==== START VALIDATION ==== >> if not "%JAVA_HOME%" == "" goto OkJHome >> >> >> >> >> > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
