I think that's a valid concern.
Could it be addressed by having a set of defaults to fall back on?
That is, try the following sources in order to get the value.
1) Maven Eclipse Plugin configuration
2) If not found above, try ${contextRoot} (or some more namespace-specific
property)
3) If not found above, pom.artifactId
I think each plugin should always be able to override the project-level value
which is why 1) is first. Then, having a common system property like
${contextRoot} would allow multiple plugins to be configured with the same
property. Finally, 3) is the currently default.
Thoughts?
K.C.
-----Original Message-----
From: Stephen Duncan [mailto:[EMAIL PROTECTED]
Sent: Friday, March 17, 2006 7:57 PM
To: Maven Developers List
Subject: Re: maven-eclipse-plugin: Question about possible patch
That does mean it would have to be duped in things like the Tomcat
plugin, Cargo, etc. though.
-Stephen
On 3/17/06, Brett Porter <[EMAIL PROTECTED]> wrote:
> The eclipse plugin sounds like the right place.
>
> - Brett
>
> KC Baltz wrote:
> > I'm preparing a patch submission for the maven-eclipse plugin to both fix a
> > bug and enhance the functionality for setting the context-root of a WTP1.0
> > project. My question is, where in the pom.xml should I have the user
> > specify the contextPath? Right now, the WtpComponentWriter grabs the
> > WebAppSrc value from the Maven War Plugin. That seems like a logical place
> > to put a contextPath/contextRoot parameter, but at the same time it's
> > probably not appropriate to put a property there that won't be used by that
> > plugin. Otherwise, the property could go under the Eclipse Plugin
> > configuration, but that feels a bit odd for some reason.
> >
> > Thoughts?
> >
> > K.C.
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>
--
Stephen Duncan Jr
www.stephenduncanjr.com
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
