Sorry, I wasn't trying to denigrate anyone, esp Brett. I think we've all written dodgy code in our day. I just got a chuckle out of the particular word choice.
Brett, I'm still getting a 403 Forbidden when I try to check in. Is there a cron job I need to wait for? -----Original Message----- From: Jesse Kuhnert [mailto:[EMAIL PROTECTED] Sent: Wednesday, May 17, 2006 1:21 PM To: Maven Developers List Subject: Re: surefire patch needs review To be fair, there was definitely more than a ~little~ bit of pressure being put on Brett at the time...This might have been something I had in one of the original patches submitted as well.... I don't think extending a junit test necessarily makes it a junit test though...Let me double check.. Yeah, TestNGClassFinder.isTestNGClass should function properly. (It's also related to a bug mentioned in the testng users forum. ) Should I try creating a new test case to double check this and submit a patch with that and any changes related to it or is someone else going to do it ? On 5/17/06, Mike Perham <[EMAIL PROTECTED]> wrote: > > I presume this is what you are talking about: > > // TODO: this is a bit dodgy, but isTestNGClass wasn't working > if ( "junit.framework.TestCase".equals( > testSet.getTestClass().getSuperclass().getName() ) ) > { > xmlTest.setJUnit( true ); > } > > Dodgy, indeed. Should it be something like this? > > clazz = Class.forName( "junit.framework.Test" ); if ( > testSet.getTestClass().isAssignableFrom( clazz ) ) { ... > } > > -----Original Message----- > From: Brett Porter [mailto:[EMAIL PROTECTED] > Sent: Wednesday, May 17, 2006 12:32 PM > To: Maven Developers List > Subject: Re: surefire patch needs review > > It looks fine, but incomplete. I'd forgotten about this better base > class, and also referenced TestCase in the TestNG provider. If you can > update that as well, then it should be fine. > > I've given you commit rights on surefire. > > Cheers, > Brett > > Mike Perham wrote: > > I have fixed http://jira.codehaus.org/browse/MSUREFIRE-113 but don't > > have commit privileges. This is a major regression versus 2.1.3 and > > for those of us who run Junit tests via suites a blocker. > > > > -------------------------------------------------------------------- > > - To unsubscribe, e-mail: [EMAIL PROTECTED] For > > additional commands, e-mail: [EMAIL PROTECTED] > > > > > -- > Apache Maven - http://maven.apache.org/ Better Builds with Maven - > http://library.mergere.com/ > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] For > additional commands, e-mail: [EMAIL PROTECTED] > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] For > additional commands, e-mail: [EMAIL PROTECTED] > > -- Jesse Kuhnert Tacos/Tapestry, team member/developer Open source based consulting work centered around dojo/tapestry/tacos/hivemind. --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
