On Fri, 19 May 2006, Brett Porter wrote:

> [EMAIL PROTECTED] wrote:
> >      /**
> > +     * Description passed to a generated POM file (in case of 
> > generatePom=true)
> > +     *
> > +     * @parameter expression="${generatePom.description}"
> > +     */
> > +    private String description = "POM was created from deploy:deploy-file";
>
> Wouldn't ${description} be more consistent?

If it's a <configuration> element, yes; if it's specified on the
commandline then I'm in favor of prefixing property names with something
so you can call multiple goals at once without risking overlapping.
Although in this case the goal would probably always be the only one
specified at the command line.

> I don't think there should be a default (and besides, defaults should be
> in default-value).

True.

-- Kenney
>
> - Brett
>
> --
> Apache Maven - http://maven.apache.org/
> Better Builds with Maven - http://library.mergere.com/
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>

--
Kenney Westerhof
http://www.neonics.com
GPG public key: http://www.gods.nl/~forge/kenneyw.key

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to