Re: svn commit: r473770 - in /maven/plugins/trunk/maven-site-plugin: ./ src/main/java/org/apache/maven/plugins/site/ src/site/apt/examples/ src/test/java/ src/test/java/org/ src/test/java/org/apache/ src/test/java/org/apache/maven/ src/test/java/org/apache...

[Brett Porter]

Hi Vincent,

Thanks for this! I think there was a JIRA for the general case which  
you might want to close as being superceded by the other one too.

I have a couple of comments unrelated to the main change:

On 12/11/2006, at 5:47 AM, [EMAIL PROTECTED] wrote:

         }
         catch ( MalformedURLException e )
         {
+            try
+            {
+                toUrl = new File( to ).toURL();
+            }
+            catch ( MalformedURLException e1 )
+            {
+                getLog().warn( "Unable to load an URL for '" + to  
+ "': " + e.getMessage() );
+            }
         }

I'm not quite sure what these would do - why would the URL be given  
as a file?

-    protected MavenProject getParentProject( MavenProject project )
+    protected MavenProject getParentProject( MavenProject aProject )

Just a nitpick - can you avoid making unrelated changes like this  
(which only changed the variable name), as it puts a lot of noise  
into the diff? Thanks :)

Cheers,
Brett


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]