On 4 Feb 07, at 3:30 PM 4 Feb 07, Brett Porter wrote:
I said the branch. I'd like this in maven 2.0.x since it's simply
swapping an implementation, but it will allow Continuum and Archiva
to stop bleeding memory.
I assumed it was going to need to be on trunk first to meet the
'develop on trunk first' requirement, but if it's a hassle that's
not a big deal.
I think there is something wrong in that we would need a cache. It's
bleeding memory why and how is a cache implementation over a HashMap
going to help?
And how long does it really take to build up a MavenProject. In the
CLI working in the reactor it helps using a HashMap. In something
like Archiva the model should be placed in a store, not cached so I
don't think it really helps there a whole lot.
I don't see why it would matter, it's just swapping implementations
- either way the cache still needs to be moved if the project
builder is cleaned up. IMO it would be better not to lose track of
the change and do it now.
The function of the cache in there was ever only the short-lived in-
session reactor so that it didn't rebuild in that case. A long-lived
app should not be pulling an object from a cache from the building to
show in an application. A cache helping a real store maybe, but in
short that HashMap in the builder was for very short-lived reasons
i.e. the reactor and the builder is probably then the wrong place for
the cache. The builder should not be in the business of caching
project objects for applications.
Jason.
- Brett
On 05/02/2007, at 10:25 AM, Jason van Zyl wrote:
Please don't apply this to the trunk until the project builder is
cleaned up.
Jason.
On 4 Feb 07, at 3:02 PM 4 Feb 07, Brett Porter wrote:
On 03/02/2007, at 3:28 PM, [EMAIL PROTECTED] wrote:
Author: joakime
Date: Fri Feb 2 20:28:21 2007
New Revision: 503171
URL: http://svn.apache.org/viewvc?view=rev&rev=503171
Log:
Updated maven-project to utilize plexus-cache w/hashmap provider.
Seems to pass all integration tests ok.
Review?
This looks fine to me. Can we apply it to the branch too?
- Brett
--------------------------------------------------------------------
-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
