Kenney Westerhof wrote:


Edwin Punzalan wrote:
Hi,


I've seen that **/pom.xml is being ignored for local modifications during a release... Although that doesn't seem right because when the release is committed, the changes will become part of the release process, I have found a use for it when dryRun=true... that is, to test a release of a modified pom without actually committing the changes yet.

So I'd like to hear your comments on what to do with it.

[1] create two separate ignore lists: one for dryRun (with **/pom.xml) and another for the actual release (without **/pom.xml)
[2] remove **/pom.xml from the ignore list
[3] do not change anything (please state your reason)

I'm for #1.

AFAIK the reason the poms are excluded is because they're modified by the
release process; if the check for local modifications is run after the pom is modified, it's impossible to do a release. So this could probably be fixed.
That's correct, the pom is modified by the release... but the phase which checks for local modifications is run a few phases before that. So its safe to remove it from the ignore list.

Btw, you're testing a release with a modified pom. What if you want to test a release with another file modified?
That's a good reason... then I guess [1] should be "if dryRun=true, the check for local modifications need not run" ?

-- Kenney

Hope to hear from you soon.


^_^

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]


---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to