On 17 Mar 07, at 12:31 AM 17 Mar 07, Ralph Goers wrote:

Jason van Zyl wrote:

I will work with Patrick to put the old and new in 2.0.x. If it really comes down to turning it off by default, which would be an immense shame, then so be it and people will just have to turn it on. We'll just devise a very easy way to turn it on like a property in the top-level POM. We can't jump from 2.0.6 to a 2.1 for this.

Jason.

Jason,

I would take the override option off the table.


I am still hoping this will go in as the default behavior and I would honestly be surprised if anyone disagrees after looking at the old versus new behavior. That said, if it gets vetoed then I was thinking a property in the POM that could get picked up.

When I wrote the patch for MNG-1577 I added an override element to the dependencyManagement element in the pom so backward compatibility could be preserved. However, I realized later that that change itself would cause problems. This is because adding anything to the pom really requires the xsd to be updated. In turn, this should require the version in the pom to be changed since it would be confusing to make a modification without updating the xsd version. So in addition to having to add <override>true</override> you would also have to change your pom version to something like 4.0.1 and reference a different xsd. Next in 2.1 presumably this element would be removed, so all the poms where this was specified might not work any longer. But with so many poms in a maven repository you can't really do that. 2.1 would be forced to at least tolerate the element so that the builds would work. Of course, what would you do in 2.1 if you encountered a pom with <override>false</override> explicitly specified?

Frankly, this seems worse than breaking compatibility in 2.0.x.

I agree. It would probably not be worth putting it in if it's not the default because no one will read anything and most likely will not enable the behavior.


Given that, the only other alternatives seem to be system properties or adding it to the settings. Neither of these is particularly attractive because if someone tries to run the build and doesn't know to have the option set then they will get different build results.

Indeed. I'll make a build this weekend and let people try it out and hope that we'll put it into 2.0.6 and give it the proper label of a corrective of a fundamental defect.

Jason.


Ralph

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to