Le vendredi 22 juin 2007, Kenney Westerhof a écrit :
> * There are multiple methods for version modification/retrieval:
>
>   * resolved version (setter only - sets version)
>   * version (sets version, baseversion, and versionrange; gets version)
>   * base version (sets base version, gets baseversion or version if
> baseversion null) * version range (sets versionrange, and sets version and
> baseversion either to null or a recommeded version; gets versionrange) *
> available versions
>   * selectVersion (sets version and baseversion)
>   * updateVersion (sets version and file)
>
>   These can be set independently and can result in an inconsistent state.
> Documentation lacks to describe which you can and which you cannot call in
> what sequences.

Yes, this is precisely what made me very careful on any patch proposal for 
MNG-2961...

>
> * isRelease is a boolean that has nothing to do with versions. I'd figure
> that if something wasn't a snapshot, it'd be a release. Guess not. Or maybe
> it is, but then the logic is someplace else.
>
>
> Simplifying this should make a whole lot of difference.
yes: perhaps add this to Architectural Goals for Maven 2.1?

>
> For now, we should update the setters to immediately update baseversion to
> -SNAPSHOT, so that even when you don't call isSNapshot, getBaseVersion is
> ok. Just updating setBaseVersion isn't enough, but it's a start. If you do
> setBaseVersion(timestamp) it'll discard the real value and replace it with
> -SNAPSHOT.
+1: I can provide a patch if it helps

Hervé

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to